git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: Mark Levedahl <mlevedahl@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	git <git@vger.kernel.org>,
	Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH] git-gui: Perform rescan on window focus-in
Date: Wed, 31 Jul 2019 21:42:07 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1907312132190.21907@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <005d7946-3fbf-9c06-21fb-51f10d06f33e@yadavpratyush.com>

Hi,

On Mon, 29 Jul 2019, Pratyush Yadav wrote:

> On 29/07/19 7:58 AM, Mark Levedahl wrote:
> > On 7/28/19 6:49 PM, brian m. carlson wrote:> On 2019-07-28 at
> > 22:10:29, Pratyush Yadav wrote:
> > > > The function is not documented, and I only started spelunking
> > > > the code a couple days back, so I'll try to answer with what I
> > > > know. It might not be the full picture.
> > > >
> > > > Running git-gui --trace, these commands are executed during a rescan:
> > > >
> > > > /usr/lib/git-core/git-rev-parse --verify HEAD
> > > > /usr/lib/git-core/git-update-index -q --unmerged --ignore-missing --refresh
> > > >
> > >
> > > Great. This sounds like a well-reasoned change. I'll let other folks who
> > > use git-gui more chime in to see what they think as well.
> > >
> >
> > I'm assuming this does what is currently done by F5.
> > A simple rescan from git-gui in the git repository takes about 8 seconds on
> > my corporate laptop running Windows, making this happen on change of window
> > focus is definitely not a friendly change from my view point.
> >
>
> This is a Windows problem maybe? On my Linux machine with an almost dead hard
> drive, it takes under 10ms to do a refresh on the git repository (which has
> about 56,000 commits).

I would be _extremely_ cautious to base an argument on one particular
setup, using on particular hardware with one particular OS and one
particular repository.

When it comes to repositories that are worked on actively, git.git is
not actually a representative example, it is way smaller than what users
deal with.

You might be one of those developers privileged enough to have a fast
computer. Trying to extrapolate from such a vantage point does the rest
of us Git users a big disservice.

At this point, I am gently inclined against the presented approach, in
particular given that even context menus reportedly trigger the re-scan
(which I suspect might actually be a Linux-only issue, as context menus
are top-level windows on X11, at least if I remember correctly, and I
also seem to remember that they are dependent windows on Aqua and Win32,
just to add yet another argument against overfitting considerations onto
a single, specific setup).

Ciao,
Johannes

  reply	other threads:[~2019-07-31 19:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-28 15:17 Pratyush Yadav
2019-07-28 21:36 ` brian m. carlson
2019-07-28 22:10   ` Pratyush Yadav
2019-07-28 22:32     ` Pratyush Yadav
2019-07-28 22:49     ` brian m. carlson
2019-07-29  2:24       ` Mark Levedahl
2019-07-29  2:26       ` Mark Levedahl
2019-07-29  2:28       ` Mark Levedahl
2019-07-29  8:15         ` Pratyush Yadav
2019-07-31 19:42           ` Johannes Schindelin [this message]
2019-08-01 21:52             ` Pratyush Yadav
2019-08-02 12:39               ` Johannes Schindelin
2019-08-02 20:00                 ` Pratyush Yadav
2019-08-03 20:34                   ` Johannes Schindelin
2019-08-04 12:53                     ` Pratyush Yadav
2019-08-04 19:10                       ` Johannes Schindelin
2019-08-04 20:17                         ` Pratyush Yadav
2019-08-02 16:47               ` Junio C Hamano
2019-08-02 20:13                 ` Pratyush Yadav
2019-08-04 18:56                   ` Johannes Schindelin
2019-07-29  5:09       ` Junio C Hamano
2019-07-29  8:44         ` Pratyush Yadav
2019-07-28 21:44 ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1907312132190.21907@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    --cc=mlevedahl@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --subject='Re: [PATCH] git-gui: Perform rescan on window focus-in' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).