From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] ci: split the `linux-gcc` job into two jobs
Date: Tue, 25 Jun 2019 10:56:06 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1906251053160.44@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1906142051300.44@tvgsbejvaqbjf.bet>
[-- Attachment #1: Type: text/plain, Size: 2308 bytes --]
Hi Gábor,
On Fri, 14 Jun 2019, Johannes Schindelin wrote:
> On Thu, 13 Jun 2019, SZEDER Gábor wrote:
>
> > On Thu, Jun 13, 2019 at 06:51:04PM +0200, Johannes Schindelin wrote:
> >
> > > On Thu, 13 Jun 2019, Junio C Hamano wrote:
> > >
> > > > SZEDER Gábor <szeder.dev@gmail.com> writes:
> > > >
> > > > > On Thu, Jun 13, 2019 at 05:53:51AM -0700, Johannes Schindelin via
> > > > > GitGitGadget wrote:
> > > > >> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> > > > >>
> > > > >> This job was abused to not only run the test suite in a regular
> > > > >> way but also with all kinds of `GIT_TEST_*` options set to
> > > > >> non-default values.
> > > > >>
> > > > >> Let's split this into two
> > > > >
> > > > > Why...?
> > > > >
> > > > >> with the `linux-gcc` job running the default test suite, and
> > > > >> the newly-introduced `linux-gcc-extra` job running the test
> > > > >> suite in the "special" ways.
> > > > >>
> > > > >> Technically, we would have to build Git only once, but it would
> > > > >> not be obvious how to teach Travis to transport build
> > > > >> artifacts, so we keep it simple and just build Git in both
> > > > >> jobs.
> > > >
> > > > I had the same reaction.
> > >
> > > So basically you are saying that the cover letter was the wrong
> > > location for this:
> > >
> > > For people like me, who often look at our CI builds, it is hard to
> > > tell whether test suite failures in the linux-gcc job stem from
> > > the first make test run, or from the second one, after setting all
> > > kinds of GIT_TEST_* variables to non-default values.
> >
> > Is this really an issue in practice?
>
> I don't think that this is the right question.
I still think that this is the wrong question.
To put more water down the drain, I would like to challenge you to look at
this build and tell me as fast as you can what half of the linux-gcc job
fails, and whether the other half of the job fails, too, or whether the
test cases succeed there, and if so, why:
https://dev.azure.com/gitgitgadget/git/_build/results?buildId=11410&view=ms.vss-test-web.build-test-results-tab
We really need to split linux-gcc. It's not right that it throws two
completely separate concerns into the same bucket.
Ciao,
Dscho
prev parent reply other threads:[~2019-06-25 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 12:53 [PATCH 0/1] ci: split linux-gcc into linux-gcc and linux-gcc-extra Johannes Schindelin via GitGitGadget
2019-06-13 12:53 ` [PATCH 1/1] ci: split the `linux-gcc` job into two jobs Johannes Schindelin via GitGitGadget
2019-06-13 15:33 ` SZEDER Gábor
2019-06-13 15:56 ` Junio C Hamano
2019-06-13 16:51 ` Johannes Schindelin
2019-06-13 17:43 ` SZEDER Gábor
2019-06-14 19:35 ` Johannes Schindelin
2019-06-25 8:56 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1906251053160.44@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).