From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: md/list-objects-filter-combo, was Re: What's cooking in git.git (Jun 2019, #05; Wed, 19)
Date: Fri, 21 Jun 2019 22:06:57 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1906212205360.44@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqef3oq3go.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, 19 Jun 2019, Junio C Hamano wrote:
> * md/list-objects-filter-combo (2019-06-17) 10 commits
> - list-objects-filter-options: make parser void
> - list-objects-filter-options: clean up use of ALLOC_GROW
> - list-objects-filter-options: allow mult. --filter
> - strbuf: give URL-encoding API a char predicate fn
> - list-objects-filter-options: make filter_spec a string_list
> - list-objects-filter-options: move error check up
> - list-objects-filter: implement composite filters
> - list-objects-filter-options: always supply *errbuf
> - list-objects-filter: put omits set in filter struct
> - list-objects-filter: make API easier to use
>
> The list-objects-filter API (used to create a sparse/lazy clone)
> learned to take a combined filter specification.
This still needs
-- snip --
diff -u -p a/list-objects-filter-options.c b/list-objects-filter-options.c
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -146,7 +146,7 @@ static int parse_combine_filter(
int result = 0;
if (!subspecs[0]) {
- strbuf_addf(errbuf,
+ strbuf_addstr(errbuf,
_("expected something after combine:"));
result = 1;
goto cleanup;
--
(see
https://dev.azure.com/gitgitgadget/git/_build/results?buildId=10925&view=logs&jobId=e7b80b24-15e8-561b-2b9b-3069817c0357&taskId=37898c85-3228-5621-0595-22d470949738&lineStart=253&lineEnd=264&colStart=1&colEnd=17)
Ciao,
Dscho
next prev parent reply other threads:[~2019-06-21 20:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 4:35 What's cooking in git.git (Jun 2019, #05; Wed, 19) Junio C Hamano
2019-06-21 19:29 ` sg/rebase-progress, was " Johannes Schindelin
2019-06-21 20:42 ` Junio C Hamano
2019-06-21 20:06 ` Johannes Schindelin [this message]
2019-06-22 9:46 ` Andrey
2019-06-24 17:05 ` Junio C Hamano
2019-06-25 9:45 ` Andrey
2019-06-25 17:44 ` Junio C Hamano
2019-07-12 2:20 ` Andrey
2019-07-12 6:11 ` Luke Diamand
2019-06-26 9:02 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1906212205360.44@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).