From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Duy Nguyen <pclouds@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 01/10] t: add helper to convert object IDs to paths
Date: Mon, 17 Jun 2019 21:05:03 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1906172102180.44@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190616185330.549436-2-sandals@crustytoothpaste.net>
Hi brian,
On Sun, 16 Jun 2019, brian m. carlson wrote:
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 8270de74be..11a6abca2e 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -1314,6 +1314,12 @@ test_oid () {
> eval "printf '%s' \"\${$var}\""
> }
>
> +# Insert a slash into an object ID so it can be used to reference a location
> +# under ".git/objects". For example, "deadbeef..." becomes "de/adbeef..".
> +test_oid_to_path () {
> + echo "$1" | sed -e 's!^..!&/!'
> +}
I guess it does not *really* matter all that much, but this does spawn a
new process (and I think it actually spawns 4 on Windows, for reasons, and
spawning processes is super expensive on Windows).
We might actually want to think about using something like this instead
(which admittedly looks a bit like gobbledygook to the uninitiated, but it
definitely avoids any spawned process):
test_oid_to_path () {
echo "${1%${1#??}}/${1#??}"
}
Ciao,
Dscho
next prev parent reply other threads:[~2019-06-17 19:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 18:53 [PATCH v2 00/10] Hash-independent tests, part 4 brian m. carlson
2019-06-16 18:53 ` [PATCH v2 01/10] t: add helper to convert object IDs to paths brian m. carlson
2019-06-17 19:05 ` Johannes Schindelin [this message]
2019-06-18 1:29 ` brian m. carlson
2019-06-18 6:14 ` Johannes Sixt
2019-06-18 16:15 ` Johannes Schindelin
2019-06-18 16:55 ` SZEDER Gábor
2019-06-19 19:56 ` Johannes Schindelin
2019-06-18 17:04 ` Jeff King
2019-06-19 19:55 ` Johannes Schindelin
2019-06-18 23:03 ` brian m. carlson
2019-06-16 18:53 ` [PATCH v2 02/10] t1410: make hash size independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 03/10] t1450: " brian m. carlson
2019-06-16 18:53 ` [PATCH v2 04/10] t5000: make hash independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 05/10] t6030: make test work with SHA-256 brian m. carlson
2019-06-16 18:53 ` [PATCH v2 06/10] t0027: make hash size independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 07/10] t0090: make test pass with SHA-256 brian m. carlson
2019-06-16 18:53 ` [PATCH v2 08/10] t1007: remove SHA1 prerequisites brian m. carlson
2019-06-16 18:53 ` [PATCH v2 09/10] t1710: make hash independent brian m. carlson
2019-06-16 18:53 ` [PATCH v2 10/10] t2203: avoid hard-coded object ID values brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1906172102180.44@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).