From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Derrick Stolee <stolee@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Barret Rhoden <brho@google.com>,
michael@platin.gs, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: Git Test Coverage Report (Thursday, May 30th)
Date: Fri, 31 May 2019 20:59:03 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1905312050330.1775@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <0d7dbfe6-53df-1df8-ac94-4dfab85bbc9f@gmail.com>
Hi Stolee,
On Fri, 31 May 2019, Derrick Stolee wrote:
> On 5/30/2019 2:24 PM, Derrick Stolee wrote:
> > Further, these tests failed
> >
> > t3400-rebase.sh (Wstat: 256 Tests: 28 Failed: 2)
> > Failed tests: 20, 28
> > Non-zero exit status: 1
> > t3420-rebase-autostash.sh (Wstat: 256 Tests: 38 Failed: 6)
> > Failed tests: 6, 13, 16, 23, 26, 33
> > Non-zero exit status: 1
> > t3404-rebase-interactive.sh (Wstat: 256 Tests: 110 Failed: 5)
> > Failed tests: 3, 9-10, 100-101
> > Non-zero exit status: 1
> > t5521-pull-options.sh (Wstat: 256 Tests: 19 Failed: 1)
> > Failed test: 3
> > Non-zero exit status: 1
> > t5551-http-fetch-smart.sh (Wstat: 256 Tests: 37 Failed: 1)
> > Failed test: 26
> > Non-zero exit status: 1
> >
> > They don't fail locally, so perhaps we shouldn't blindly trust the coverage data
> > until I work out why these errors occurred. (Many of the cases I called out
> > above I couldn't hit locally with a die() statement.)
>
> These tests all failed during the second run that set optional GIT_TEST
> environment variables. Specifically, GIT_TEST_REBASE_USE_BUILTIN=false
> caused these tests to break. We now output this message:
>
> warning: the rebase.useBuiltin support has been removed!
> See its entry in 'git help config' for details.
>
> I'm removing that variable from the build definition.
Would it make sense to have a file in t/ (or a script-let in ci/)
specifying all of the `GIT_TEST_*` variables that are currently supported
(and that actually make sense to be set)?
I saw a similar issue recently in a now-defunct Azure Pipeline that also
tried to replicate what half of the `linux-gcc` job [*1*] does: to run the
test suite with those variables overriding the defaults. That Pipeline
broke for the exact same reason you mentioned: we now handle
`GIT_TEST_REBASE_USE_BUILTIN` by showing that warning.
And issues like this could easily be avoided if we had, say,
`ci/non-standard-settings.sh` that simply set all those `GIT_TEST_*`
variables in the way that the `linux-gcc` job does (and of course, this
job should then source that file instead of duplicating those
assignments).
What do you think?
Dscho
Footnote *1*: It is a thorn in my side ever since I started work on our
Azure Pipeline support that the `linux-gcc` job actually runs *two* jobs:
it runs the vanilla test suite, and then it runs it again after setting
all supported `GIT_TEST_*` variables to the non-default settings. This
almost doubles the running time of that job, often making it the very last
job to finish, and it also makes it unclear whether a test failure stems
from said `GIT_TEST_*` settings or not.
I got so annoyed by this, in fact, that I finally broke down and opened
https://github.com/gitgitgadget/git/issues/242.
next prev parent reply other threads:[~2019-05-31 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 12:52 Git Test Coverage Report (Thursday, May 30th) Derrick Stolee
2019-05-30 18:24 ` Derrick Stolee
2019-05-31 17:51 ` Derrick Stolee
2019-05-31 18:59 ` Johannes Schindelin [this message]
2019-06-01 21:22 ` Michael Platings
2019-06-03 18:11 ` Barret Rhoden
2019-06-03 18:40 ` Derrick Stolee
2019-06-04 16:38 ` Barret Rhoden
2019-06-04 20:41 ` Barret Rhoden
2019-06-05 0:57 ` Derrick Stolee
2019-06-10 15:15 ` Barret Rhoden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1905312050330.1775@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=brho@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=michael@platin.gs \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).