From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <dstolee@microsoft.com>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2019, #04; Tue, 28)
Date: Thu, 30 May 2019 17:01:53 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1905301659070.44@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190530115122.GA31607@sigill.intra.peff.net>
Hi Peff,
On Thu, 30 May 2019, Jeff King wrote:
> On Wed, May 29, 2019 at 09:53:44AM -0700, Junio C Hamano wrote:
>
> > >> * ds/object-info-for-prefetch-fix (2019-05-28) 1 commit
> > >> - sha1-file: split OBJECT_INFO_FOR_PREFETCH
> > >>
> > >> Code cleanup.
> > >>
> > >> Will merge to 'next'.
> > >
> > > I think this one is actually a bug-fix (we are refusing to prefetch for
> > > "QUICK" calls even though was not the intent), and it is new in this
> > > release.
> > >
> > > I'm not sure of the user-visible impacts, though. There are a lot of
> > > QUICK calls, and I'm not sure for which ones it is important to fetch.
> >
> > Hmph. I took it as primarily futureproofing, as I didn't find a way
> > to trigger bad behaviour from within the current codebase.
>
> Hmm. Looking over the uses of OBJECT_INFO_QUICK, they all seem to be in
> either index-pack or as part of a fetch operation. And in both of those
> cases, we'd disable the whole feature anyway with fetch_if_missing.
>
> So I _think_ you are right, and there isn't a way to trigger it.
FWIW that was also my impression, but then, I did not look very closely.
In an attempt to find regressions (and to fix them) during the -rc phase,
we rebased VFSforGit's patches on top of current `master`, and saw this
issue. But yeah, the issue fixed by Stolee's patch seems to be caused by
the interaction between current `master` and the VFSforGit patches.
Thanks,
Dscho
next prev parent reply other threads:[~2019-05-30 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 22:08 What's cooking in git.git (May 2019, #04; Tue, 28) Junio C Hamano
2019-05-28 22:26 ` Jeff King
2019-05-29 16:53 ` Junio C Hamano
2019-05-30 11:51 ` Jeff King
2019-05-30 15:01 ` Johannes Schindelin [this message]
2019-05-30 18:29 ` Derrick Stolee
2019-05-29 12:26 ` ab/send-email-transferencoding-fix, was " Johannes Schindelin
2019-05-29 12:36 ` Ævar Arnfjörð Bjarmason
2019-05-29 17:31 ` Junio C Hamano
2019-05-29 18:10 ` Johannes Schindelin
2019-05-29 19:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1905301659070.44@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).