From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] index-pack: prefetch missing REF_DELTA bases
Date: Fri, 17 May 2019 20:33:45 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1905172032550.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190515182812.107420-1-jonathantanmy@google.com>
Hi Jonathan,
On Wed, 15 May 2019, Jonathan Tan wrote:
> > > To resolve this, prefetch all missing REF_DELTA bases before attempting
> > > to resolve them. This both ensures that all bases are attempted to be
> > > fetched, and ensures that we make only one request per index-pack
> > > invocation, and not one request per missing object.
> >
> > Hmm. I wonder whether this can lead to *really* undesirable behavior, e.g.
> > with deep delta chains. The client would possibly have to fetch the
> > REF_DELTA object, but that would also be delivered in a thin pack with
> > *another* REF_DELTA object, and the same over and over again, with plenty
> > of round trips that kill performance really well.
>
> When the client fetches the REF_DELTA base, it won't be a REF_DELTA
> object itself because Git makes these fetches without any "have" lines,
> so the server doesn't know anything to delta against. Admittedly, this
> is just due how to we implemented it - if later we find a way to
> optimize the lazy fetches by adding "have", then we'll have to revisit
> this.
Ah! I *think* I understand this better now. Thank you.
> Quoting from the commit message:
>
> > > (When fetching REF_DELTA bases, it is unlikely that
> > > those are REF_DELTA themselves, because we do not send "have" when
> > > making such fetches.)
>
> I tried to address this point with this sentence in the commit message.
> If you think that this should be addressed more clearly in the commit
> message, let me know if you have any suggestions.
I totally read over this part of the commit message, apparently. My bad.
Sorry for the noise!
Dscho
next prev parent reply other threads:[~2019-05-17 18:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 21:10 [PATCH 0/2] Partial clone fix: handling received REF_DELTA Jonathan Tan
2019-05-14 21:10 ` [PATCH 1/2] t5616: refactor packfile replacement Jonathan Tan
2019-05-15 8:36 ` Johannes Schindelin
2019-05-15 18:22 ` Jonathan Tan
2019-05-14 21:10 ` [PATCH 2/2] index-pack: prefetch missing REF_DELTA bases Jonathan Tan
2019-05-15 8:46 ` Johannes Schindelin
2019-05-15 18:28 ` Jonathan Tan
2019-05-17 18:33 ` Johannes Schindelin [this message]
2019-05-15 23:16 ` Jeff King
2019-05-16 1:43 ` Junio C Hamano
2019-05-16 4:04 ` Jeff King
2019-05-16 18:26 ` Jonathan Tan
2019-05-16 21:12 ` Jeff King
2019-05-16 21:30 ` Jonathan Tan
2019-05-16 21:42 ` Jeff King
2019-05-16 23:15 ` Jonathan Tan
2019-05-17 1:09 ` Jeff King
2019-05-17 1:22 ` Jeff King
2019-05-17 4:39 ` Jeff King
2019-05-17 4:42 ` Jeff King
2019-05-17 7:20 ` Duy Nguyen
2019-05-17 8:55 ` Jeff King
2019-05-18 11:39 ` Duy Nguyen
2019-05-20 23:04 ` Nicolas Pitre
2019-05-21 21:20 ` Jeff King
2019-06-03 22:23 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1905172032550.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).