From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Thomas Braun via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Thomas Braun <thomas.braun@byte-physics.de>
Subject: Re: [PATCH 1/1] mingw: optionally disable side-band-64k for transport
Date: Tue, 30 Apr 2019 18:33:47 -0400 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1904301832500.45@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <b8e799e2-356d-2a03-faa4-2792ec1b171d@kdbg.org>
Hi Hannes,
On Tue, 30 Apr 2019, Johannes Sixt wrote:
> Am 30.04.19 um 01:17 schrieb Johannes Schindelin:
> > On Mon, 29 Apr 2019, Eric Sunshine wrote:
> >> On Mon, Apr 29, 2019 at 6:04 PM Thomas Braun via GitGitGadget
> >>> diff --git a/Documentation/config/sendpack.txt b/Documentation/config/sendpack.txt
> >>> @@ -0,0 +1,5 @@
> >>> +sendpack.sideband::
> >>> + Allows to disable the side-band-64k capability for send-pack even
> >>> + when it is advertised by the server. Makes it possible to work
> >>> + around a limitation in the git for windows implementation together
> >>> + with the dump git protocol. Defaults to true.
> >>
> >> s/dump/dumb/
> >>
> >> For someone who hasn't read the commit message of this patch, "work
> >> around a limitation in ... git for windows" doesn't mean much. Perhaps
> >> this documentation could explain in more precise terms under what
> >> circumstances this option should be used?
> >
> > You're right, this is confusing, especially since Git for Windows 2.x does
> > not have that bug.
>
> If there is no bug, why do we need the patch?
I thought you of all people (building with the ancient MSys/MINGW
toolchains) would benefit from it :-)
But if even you don't want it, I'll gladly drop it from Git for Windows'
patches and be done with it.
Ciao,
Dscho
next prev parent reply other threads:[~2019-04-30 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 22:04 [PATCH 0/1] Support git:// with old MinGW Johannes Schindelin via GitGitGadget
2019-04-29 22:04 ` [PATCH 1/1] mingw: optionally disable side-band-64k for transport Thomas Braun via GitGitGadget
2019-04-29 22:10 ` Eric Sunshine
2019-04-29 23:17 ` Johannes Schindelin
2019-04-30 6:21 ` Johannes Sixt
2019-04-30 22:33 ` Johannes Schindelin [this message]
2019-04-30 22:55 ` Johannes Sixt
2019-05-03 8:42 ` Johannes Schindelin
2019-04-29 23:19 ` brian m. carlson
2019-04-30 22:37 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1904301832500.45@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=sunshine@sunshineco.com \
--cc=thomas.braun@byte-physics.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).