[GSoC] [t9803]

[GSoC] [t9803]

[Julian Cheng]

Hello Git Community,

I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject

Main Project Quesctions
I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.

Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?


Microproject Questions (test_path_is_*)
I would like to improve t9803-git-p4-shell-metachars.sh 

On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?

To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?

Best,
Julian

Re: [GSoC] [t9803]

[Denton Liu]

Hi Julian,

On Wed, Mar 27, 2019 at 07:26:12PM +0000, Julian Cheng wrote:
> Hello Git Community,
> 
> I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
> 
> Main Project Quesctions
> I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.
> 
> Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?
> 
> 
> Microproject Questions (test_path_is_*)
> I would like to improve t9803-git-p4-shell-metachars.sh 
> 
> On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?
> 
> To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?

When the tests run, they don't test your installation (the git you're
currently using in /usr/bin/git). They test the git you've built in the
project directory.

First of all, you should build the project. You should run "make" from
the top-level directory of git. This will fill the directory with git-*
executables. These are the actual binaries that will be tested.

Next, go into t/ and run "make" again to run all of the tests. You can
also run individual tests by doing something like
./t9803-git-p4-shell-metachars.sh, for example.

For even more details on testing, see t/README.

Also, some other helpful documentation to read include:

* Documentation/SubmittingPatches
* Documentation/CodingGuidelines

Hope this helps,

Denton

> 
> Best,
> Julian

RE: [GSoC] [t9803]

[Julian Cheng]

Denton, thanks for the pointers!

I get the following when I run "make" in the top level directory of git and I'm not sure how to deal with it. Any ideas?
$ make
    LINK git-http-fetch
.../lib/libcurl.so: undefined reference to `SSLv2_client_method'
collect2: error: ld returned 1 exit status
Makefile:2434: recipe for target 'git-http-fetch' failed
make: *** [git-http-fetch] Error 1

________________________________________
From: Denton Liu [liu.denton@gmail.com]
Sent: March-27-19 5:10 PM
To: Julian Cheng
Cc: git@vger.kernel.org
Subject: Re: [GSoC] [t9803]

Hi Julian,

On Wed, Mar 27, 2019 at 07:26:12PM +0000, Julian Cheng wrote:
> Hello Git Community,
>
> I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
>
> Main Project Quesctions
> I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.
>
> Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?
>
>
> Microproject Questions (test_path_is_*)
> I would like to improve t9803-git-p4-shell-metachars.sh
>
> On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?
>
> To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?

When the tests run, they don't test your installation (the git you're
currently using in /usr/bin/git). They test the git you've built in the
project directory.

First of all, you should build the project. You should run "make" from
the top-level directory of git. This will fill the directory with git-*
executables. These are the actual binaries that will be tested.

Next, go into t/ and run "make" again to run all of the tests. You can
also run individual tests by doing something like
./t9803-git-p4-shell-metachars.sh, for example.

For even more details on testing, see t/README.

Also, some other helpful documentation to read include:

* Documentation/SubmittingPatches
* Documentation/CodingGuidelines

Hope this helps,

Denton

>
> Best,
> Julian

Re: [GSoC] [t9803]

[Denton Liu]

On Wed, Mar 27, 2019 at 10:04:46PM +0000, Julian Cheng wrote:
> Denton, thanks for the pointers!
> 
> I get the following when I run "make" in the top level directory of git and I'm not sure how to deal with it. Any ideas?
> $ make
>     LINK git-http-fetch
> .../lib/libcurl.so: undefined reference to `SSLv2_client_method'
> collect2: error: ld returned 1 exit status
> Makefile:2434: recipe for target 'git-http-fetch' failed
> make: *** [git-http-fetch] Error 1

What OS and/or distro are you currently running? It looks like you
either have some out-of-date libraries or you're entirely missing some
libraries.

> 
> ________________________________________
> From: Denton Liu [liu.denton@gmail.com]
> Sent: March-27-19 5:10 PM
> To: Julian Cheng
> Cc: git@vger.kernel.org
> Subject: Re: [GSoC] [t9803]
> 
> Hi Julian,
> 
> On Wed, Mar 27, 2019 at 07:26:12PM +0000, Julian Cheng wrote:
> > Hello Git Community,
> >
> > I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
> >
> > Main Project Quesctions
> > I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.
> >
> > Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?
> >
> >
> > Microproject Questions (test_path_is_*)
> > I would like to improve t9803-git-p4-shell-metachars.sh
> >
> > On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?
> >
> > To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?
> 
> When the tests run, they don't test your installation (the git you're
> currently using in /usr/bin/git). They test the git you've built in the
> project directory.
> 
> First of all, you should build the project. You should run "make" from
> the top-level directory of git. This will fill the directory with git-*
> executables. These are the actual binaries that will be tested.
> 
> Next, go into t/ and run "make" again to run all of the tests. You can
> also run individual tests by doing something like
> ./t9803-git-p4-shell-metachars.sh, for example.
> 
> For even more details on testing, see t/README.
> 
> Also, some other helpful documentation to read include:
> 
> * Documentation/SubmittingPatches
> * Documentation/CodingGuidelines
> 
> Hope this helps,
> 
> Denton
> 
> >
> > Best,
> > Julian

RE: [GSoC] [t9803]

[Julian Cheng]

I'm running Ubuntu 16.04. "sudo apt-get upgrade" tell me I'm up to date. I hope it's not just that I'm not running a more recent Ubuntu.
________________________________________
From: Denton Liu [liu.denton@gmail.com]
Sent: March-27-19 6:51 PM
To: Julian Cheng
Cc: git@vger.kernel.org
Subject: Re: [GSoC] [t9803]

On Wed, Mar 27, 2019 at 10:04:46PM +0000, Julian Cheng wrote:
> Denton, thanks for the pointers!
>
> I get the following when I run "make" in the top level directory of git and I'm not sure how to deal with it. Any ideas?
> $ make
>     LINK git-http-fetch
> .../lib/libcurl.so: undefined reference to `SSLv2_client_method'
> collect2: error: ld returned 1 exit status
> Makefile:2434: recipe for target 'git-http-fetch' failed
> make: *** [git-http-fetch] Error 1

What OS and/or distro are you currently running? It looks like you
either have some out-of-date libraries or you're entirely missing some
libraries.

>
> ________________________________________
> From: Denton Liu [liu.denton@gmail.com]
> Sent: March-27-19 5:10 PM
> To: Julian Cheng
> Cc: git@vger.kernel.org
> Subject: Re: [GSoC] [t9803]
>
> Hi Julian,
>
> On Wed, Mar 27, 2019 at 07:26:12PM +0000, Julian Cheng wrote:
> > Hello Git Community,
> >
> > I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
> >
> > Main Project Quesctions
> > I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.
> >
> > Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?
> >
> >
> > Microproject Questions (test_path_is_*)
> > I would like to improve t9803-git-p4-shell-metachars.sh
> >
> > On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?
> >
> > To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?
>
> When the tests run, they don't test your installation (the git you're
> currently using in /usr/bin/git). They test the git you've built in the
> project directory.
>
> First of all, you should build the project. You should run "make" from
> the top-level directory of git. This will fill the directory with git-*
> executables. These are the actual binaries that will be tested.
>
> Next, go into t/ and run "make" again to run all of the tests. You can
> also run individual tests by doing something like
> ./t9803-git-p4-shell-metachars.sh, for example.
>
> For even more details on testing, see t/README.
>
> Also, some other helpful documentation to read include:
>
> * Documentation/SubmittingPatches
> * Documentation/CodingGuidelines
>
> Hope this helps,
>
> Denton
>
> >
> > Best,
> > Julian

Re: [GSoC] [t9803]

[Denton Liu]

On Wed, Mar 27, 2019 at 11:01:38PM +0000, Julian Cheng wrote:
> I'm running Ubuntu 16.04. "sudo apt-get upgrade" tell me I'm up to date. I hope it's not just that I'm not running a more recent Ubuntu.

I am running Ubuntu 16.04 currently as well, so that shouldn't be a
problem.

Admittedly, I'm not too familiar with curl or openssl (and Ubuntu for
that matter, I typically use a different distro) but I believe that a
workaround would be to replace your libcurl4-openssl-dev with
libcurl4-gnutls-dev. I believe this should work unless you have a strong
reason against it.

> ________________________________________
> From: Denton Liu [liu.denton@gmail.com]
> Sent: March-27-19 6:51 PM
> To: Julian Cheng
> Cc: git@vger.kernel.org
> Subject: Re: [GSoC] [t9803]
> 
> On Wed, Mar 27, 2019 at 10:04:46PM +0000, Julian Cheng wrote:
> > Denton, thanks for the pointers!
> >
> > I get the following when I run "make" in the top level directory of git and I'm not sure how to deal with it. Any ideas?
> > $ make
> >     LINK git-http-fetch
> > .../lib/libcurl.so: undefined reference to `SSLv2_client_method'
> > collect2: error: ld returned 1 exit status
> > Makefile:2434: recipe for target 'git-http-fetch' failed
> > make: *** [git-http-fetch] Error 1
> 
> What OS and/or distro are you currently running? It looks like you
> either have some out-of-date libraries or you're entirely missing some
> libraries.
> 
> >
> > ________________________________________
> > From: Denton Liu [liu.denton@gmail.com]
> > Sent: March-27-19 5:10 PM
> > To: Julian Cheng
> > Cc: git@vger.kernel.org
> > Subject: Re: [GSoC] [t9803]
> >
> > Hi Julian,
> >
> > On Wed, Mar 27, 2019 at 07:26:12PM +0000, Julian Cheng wrote:
> > > Hello Git Community,
> > >
> > > I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
> > >
> > > Main Project Quesctions
> > > I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas page lists mentors for other projects but not this one.
> > >
> > > Also, “git revert --drop” and “git commit --reword” appear not to have been discussed yet in the public inbox. Is this correct or am I just not finding the threads?
> > >
> > >
> > > Microproject Questions (test_path_is_*)
> > > I would like to improve t9803-git-p4-shell-metachars.sh
> > >
> > > On the microprojects page, it suggests I should run the tests to make sure they all pass. But if I’m making changes to the tests, is it really adequate testing just to make sure they all pass?
> > >
> > > To run all tests, I assume I would just navigate to the tests folder in terminal and call “sh *.sh”, but that doesn’t seem to work. Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error: GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely installed on my computer though. I’ve been using it for months. I cloned this repo with Git. What am I missing here?
> >
> > When the tests run, they don't test your installation (the git you're
> > currently using in /usr/bin/git). They test the git you've built in the
> > project directory.
> >
> > First of all, you should build the project. You should run "make" from
> > the top-level directory of git. This will fill the directory with git-*
> > executables. These are the actual binaries that will be tested.
> >
> > Next, go into t/ and run "make" again to run all of the tests. You can
> > also run individual tests by doing something like
> > ./t9803-git-p4-shell-metachars.sh, for example.
> >
> > For even more details on testing, see t/README.
> >
> > Also, some other helpful documentation to read include:
> >
> > * Documentation/SubmittingPatches
> > * Documentation/CodingGuidelines
> >
> > Hope this helps,
> >
> > Denton
> >
> > >
> > > Best,
> > > Julian

Re: [GSoC] [t9803]

[Johannes Schindelin]

[-- Attachment #1: Type: text/plain, Size: 2449 bytes --]

Hi Julian,

On Wed, 27 Mar 2019, Julian Cheng wrote:

> I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
>
> Main Project Quesctions
> I was hoping to work on “git revert --drop” and “git commit --reword”.
> Are there any mentors available for this project? The ideas page lists
> mentors for other projects but not this one.

I cannot speak for the available mentors, but I would imagine that all of
them have the technical knowledge to mentor this.

> Also, “git revert --drop” and “git commit --reword” appear not to have
> been discussed yet in the public inbox. Is this correct or am I just not
> finding the threads?

I mentioned this idea in
https://public-inbox.org/git/alpine.DEB.2.21.1.1710151754070.40514@virtualbox/

> Microproject Questions (test_path_is_*)
> I would like to improve t9803-git-p4-shell-metachars.sh
>
> On the microprojects page, it suggests I should run the tests to make
> sure they all pass. But if I’m making changes to the tests, is it really
> adequate testing just to make sure they all pass?

You should of course read the test cases in order to understand what they
cover and what they do not cover, and add test cases if there is something
important that your patch might affect.

> To run all tests, I assume I would just navigate to the tests folder in
> terminal and call “sh *.sh”, but that doesn’t seem to work.

There is exactly one way how it can work. But there are a million ways how
it can fail, so you'll have to be more specific how it "doesn't seem to
work".

> Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error:
> GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely
> installed on my computer though. I’ve been using it for months. I cloned
> this repo with Git. What am I missing here?

You have to build it first, by navigating to the top-level directory and
calling `make

You have to build it first, by navigating to the top-level directory and
calling `make` (I like to use `-j(nproc)` to build in parallel, you might
want to use that, too).

Alternatively, you can set `GIT_TEST_INSTALLED` to the absolute path of
your `git` executable, but it'd be better to build from the current
revision (the installed Git might have different semantics if it is a much
older version).

Ciao,
Johannes