From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Junio C Hamano <email@example.com> Cc: Johannes Schindelin via GitGitGadget <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 0/1] Drop last MakeMaker reference Date: Fri, 8 Mar 2019 17:27:36 +0100 (STD) [thread overview] Message-ID: <nycvar.QRO.firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Hi Junio, On Fri, 8 Mar 2019, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > On Sun, 3 Mar 2019, Junio C Hamano wrote: > > > >> "Johannes Schindelin via GitGitGadget" <firstname.lastname@example.org> > >> writes: > >> > >> > Back when we stopped using MakeMaker, we forgot one reference... > >> > > >> > Johannes Schindelin (1): > >> > mingw: drop MakeMaker reference > >> > > >> > config.mak.uname | 1 - > >> > 1 file changed, 1 deletion(-) > >> > > >> > > >> > base-commit: 8104ec994ea3849a968b4667d072fedd1e688642 > >> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-146%2Fdscho%2Fno-perl-makemaker-v1 > >> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-146/dscho/no-perl-makemaker-v1 > >> > Pull-Request: https://github.com/gitgitgadget/git/pull/146 > >> > >> Good ;-) > >> Thanks. > > > > Gentle reminder that this has not made it into `pu` yet... > > Thanks. > > I'll try to make it a habit not to respond to 0/1 (but instead to > 1/1) as it is quite inefficient to get to 1/1 from 0/1 at least for > me X-<. Hehe. I do have something for you there: https://github.com/git-for-windows/build-extra/blob/master/apply-from-public-inbox.sh -- snip -- > Or perhaps GGG can learn to avoid 0/1 for a single-patch topic ;-) It is easier, and more consistent, to have a cover letter even then, for things like the broader explanation of the context, the changes since the previous iteration, and the range-diff (which would make v2, v3, v4, etc utterly unreadable from my point of view if they were integrated into the single patches, as I used to do with interdiffs). > Thanks anyway. Will try to apply directly on top of master. Thank you! While we're talking about "directly on top of master"... *after* it got some review, I would love to ask for the same favor for https://email@example.com On the other hand, it is an old bug, I know, and it will break all CI builds for branches that are based off of older commits, anyway. I guess we'll need some sort of horrible hack in the git-sdk-64-minimal thing, to allow for patching this on the CI side, without adding commits to all of those branches. :-( So: I made up my mind, and that MSYS2 runtime v3.x patch does not need to be fast-tracked; it would not fix all the CI builds... Ciao, Dscho
next prev parent reply other threads:[~2019-03-08 16:27 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-25 19:27 Johannes Schindelin via GitGitGadget 2019-02-25 19:27 ` [PATCH 1/1] mingw: drop " Johannes Schindelin via GitGitGadget 2019-02-25 20:02 ` Jonathan Nieder 2019-02-25 22:07 ` Johannes Schindelin 2019-03-03 1:19 ` [PATCH 0/1] Drop last " Junio C Hamano 2019-03-07 10:10 ` Johannes Schindelin 2019-03-08 1:41 ` Junio C Hamano 2019-03-08 16:27 ` Johannes Schindelin [this message] 2019-03-11 20:24 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 0/1] Drop last MakeMaker reference' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).