From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] mingw: drop MakeMaker reference
Date: Mon, 25 Feb 2019 23:07:03 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1902252304180.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190225200225.GA16965@google.com>
Hi Jonathan,
On Mon, 25 Feb 2019, Jonathan Nieder wrote:
> Johannes Schindelin via GitGitGadget wrote:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > In 20d2a30f8ffe (Makefile: replace perl/Makefile.PL with simple make
> > rules, 2017-12-10), Git stopped using MakeMaker. Therefore, that
> > definition in the MINGW-specific section became useless.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > config.mak.uname | 1 -
> > 1 file changed, 1 deletion(-)
>
> Yay!
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks!
> Is there a way to automate checking for make variables that are set
> but never used?
No, not that I know of...
The biggest problem is that we only add documentation to the beginning of
the Makefile by convention, and there is not really any consistent way to
parse that documentation to figure out what build variables are handled
currently.
Ciao,
Dscho
next prev parent reply other threads:[~2019-02-25 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 19:27 [PATCH 0/1] Drop last MakeMaker reference Johannes Schindelin via GitGitGadget
2019-02-25 19:27 ` [PATCH 1/1] mingw: drop " Johannes Schindelin via GitGitGadget
2019-02-25 20:02 ` Jonathan Nieder
2019-02-25 22:07 ` Johannes Schindelin [this message]
2019-03-03 1:19 ` [PATCH 0/1] Drop last " Junio C Hamano
2019-03-07 10:10 ` Johannes Schindelin
2019-03-08 1:41 ` Junio C Hamano
2019-03-08 16:27 ` Johannes Schindelin
2019-03-11 20:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1902252304180.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).