From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Rohit Ashiwal <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [GSoC] Introduction Date: Sun, 24 Feb 2019 15:47:08 +0100 (STD) [thread overview] Message-ID: <nycvar.QRO.email@example.com> (raw) In-Reply-To: <CAL7ArXqkVfrnQWYFDYdwMGkZjHCwzyQX4pbKCo=KCzy-zJiRBw@mail.gmail.com> Hi Rohit, On Sun, 24 Feb 2019, Rohit Ashiwal wrote: > Hello Hi there! > I am Rohit Ashiwal, a computer science and engineering student from > IIT Roorkee. I am a git user for 2 years now and want to contribute > towards its development. Great! > I have read the microproject list available [here](1) and project > titled `Use test_path_is_* functions in test scripts` caught my eye. > I want to work on this one if anyone is not working on it (I was not > able to find related threads on public-inbox). Go for it ;-) The microprojects are basically a straight-forward way to introduce prospective GSoC students to Git's code contribution process. In that sense, while it would be better for students not to have overlapping microprojects, it is not the end of the world, either. In your case, it is relatively easy to figure out that no other student mentioned this project on the Git mailing list: https://public-inbox.org/git/?q=test_path_is_file > I am somewhat familiar with git's code as I was previously working on > git-for-windows and I have solved 1 [issue](2), which is a reason for > my concern. Should this count as a microproject? As the webpage > instructs us to work only on 1 microproject. True. You could brush up that pair of patches to teach `git archive` to avoid spawning `gzip` when generating `.tar.gz` archives, and submit them using the process suggested in https://git-scm.com/docs/SubmittingPatches. (You might want to make it easier on yourself and use GitGitGadget, which takes out the challenge of sending patches in the required format via email, see https://gitgitgadget.github.io/ for details.) On the other hand, it might make more sense to start afresh with the test_path_is_* microproject, as I already took custody of your patches and planned on submitting them (via GitGitGadget) right after v2.21.0 comes out. > If you disregard that contribution, here is my approach to solving > this microproject: search for `test -f` in `t/**` and replace all > occurrences with `test_path_is_file` and similarly for other mentioned > commands. Is it correct? This is a good first step, indeed. You may want to be careful about it, though, as there *might* be instances where replacing the `test -f` would not make sense (such as instances where scripts are written via `write_script`, and those scripts would not have access to the `test_path_is_file` function). You probably also want to inspect instances of `test -e` (which technically only ask whether a path exists, whether it is a file, a directory, or a symbolic link), as it might be possible that some tests use that invocation when they really want to ask whether a file exists. Then, you want to also look for `test -d` for the `test_path_is_dir` conversion. Good luck, Johannes
next prev parent reply other threads:[~2019-02-24 14:47 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-24 10:05 Rohit Ashiwal 2019-02-24 14:47 ` Johannes Schindelin [this message] 2019-02-25 6:50 ` Christian Couder 2019-02-25 11:35 ` Rohit Ashiwal 2019-02-25 20:21 ` Christian Couder 2019-02-25 21:09 ` Eric Sunshine 2019-03-22 15:11 ` [GSoC][RFC] Proposal: Improve consistency of sequencer commands Rohit Ashiwal 2019-03-23 22:17 ` Christian Couder 2019-03-24 1:21 ` Rohit Ashiwal 2019-03-24 1:07 ` Elijah Newren 2019-03-24 1:45 ` Rohit Ashiwal 2019-03-29 22:32 ` [GSoC][RFC v2] " Rohit Ashiwal 2019-03-29 23:25 ` Elijah Newren 2019-03-29 23:34 ` Rohit Ashiwal 2019-03-30 0:38 ` Elijah Newren 2019-03-30 8:48 ` Rohit Ashiwal 2019-03-30 17:13 ` Elijah Newren 2019-03-30 7:16 ` Christian Couder 2019-03-30 17:12 ` Elijah Newren 2019-04-05 21:31 ` [GSoC][RFC v3] Proposal: " Rohit Ashiwal 2019-04-07 7:15 ` Christian Couder 2019-04-07 12:16 ` Rohit Ashiwal 2019-04-07 23:07 ` Christian Couder -- strict thread matches above, loose matches on Subject: below -- 2020-01-22 20:42 [GSoC] Introduction Shourya Shukla 2020-01-23 11:02 ` Christian Couder 2020-01-23 18:04 ` Shourya Shukla 2020-01-23 22:51 ` Christian Couder 2020-01-01 13:02 [GSOC] Introduction Hariom verma 2020-01-23 11:16 ` Christian Couder 2020-01-23 20:18 ` Hariom verma 2020-01-23 22:38 ` Christian Couder 2015-03-07 11:25 karthik nayak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GSoC] Introduction' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).