From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
"'Max Kirillov'" <max@max630.net>,
"'SZEDER Gábor'" <szeder.dev@gmail.com>,
git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News
Date: Mon, 18 Feb 2019 20:37:43 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1902182008270.45@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq5ztj4l3j.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Sat, 16 Feb 2019, Junio C Hamano wrote:
> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
>
> >> > The current condition of the code is (the generate_zero_bytes delete
> >> > was previously removed so can be ignored for the patch):
> >>
> >> Just to make sure I do not misunderstand, this result is with Max's patch but
> >> without the generate_zero_bytes stuff?
> >
> > Correct.
>
> Thanks for a quick response. I've been staring at b46221ff ("Merge
> branch 'rb/no-dev-zero-in-test'", 2019-02-13). IIUC, t5562 wouldn't
> have passed if it still fed http-backend from /dev/zero, no? The
> shell redirection would have failed, so we do need to keep that part
> of the change---i.e. in order to pass, we do need cc95bc20 ("t5562:
> replace /dev/zero with a pipe from generate_zero_bytes", 2019-02-09)
> and Max's "t5562: do not reuse output files", right?
>
> I have been wondering about the whole /dev/zero business. Although
> we have b46221ff ("Merge branch 'rb/no-dev-zero-in-test'",
> 2019-02-13) in 'master', "git grep /dev/zero t" has hits in
> t/helper/test-sha1.sh and t/t4152-am-resume-override-opts.sh, so it
> must have been somewhat incomplete to help platforms that lack
> /dev/zero in the first place.
>
> We haven't heard from Dscho in European timezone,
Some bacteria redirected me to /dev/zero for a few days. That hung my
inbox.
> but I'm inclined to
>
> - keep b46221ff in 'master', not reverted.
> - apply Max's "t5562: do not reuse output files"
>
> to 'master' and hope that we can declare victory in this part of the
> code ;-). There may be fix-ups for other topics before -rc2 on top
> of that, though.
For the record, I did not set up that fully automated PR build & test at
https://github.com/gitgitgadget/git just so people would still wait for me
to run the test; a simple PR would have tested this without waiting for
me.
Anyway, in the meantime, I tested it, and Max' test seems to work:
https://dev.azure.com/git-for-windows/git/_build/results?buildId=31274
Ciao,
Dscho
> >> Thanks, all. Hopefully we can get this test failures behind us before -rc2;
> >> knock, knock...
> >
> > Once the fix is integrated and in the usual spots, I can verify
> > with haste. The full test cycle is now at 50 hours (argh), which I
> > will rerun in full at rc2, but this one is fast.
>
next prev parent reply other threads:[~2019-02-18 19:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 16:51 [ANNOUNCE] Git v2.21.0-rc1 (NonStop Results) - Good News Randall S. Becker
2019-02-16 17:02 ` Randall S. Becker
2019-02-16 18:05 ` Junio C Hamano
2019-02-16 18:24 ` Randall S. Becker
2019-02-16 18:57 ` Junio C Hamano
2019-02-18 18:45 ` Junio C Hamano
2019-02-18 18:50 ` Randall S. Becker
2019-02-19 10:05 ` Johannes Schindelin
2019-02-18 19:37 ` Johannes Schindelin [this message]
2019-02-18 21:57 ` Johannes Schindelin
2019-02-19 20:15 ` Max Kirillov
2019-02-19 20:36 ` Max Kirillov
2019-02-19 20:53 ` Randall S. Becker
2019-02-20 20:15 ` Johannes Schindelin
2019-02-18 20:24 ` Max Kirillov
2019-02-18 20:31 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1902182008270.45@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
--cc=rsbecker@nexbridge.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).