git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: SZEDER Gábor <szeder.dev@gmail.com>
Cc: Ævar Arnfjörð Bjarmason  <avarab@gmail.com>,
	Duy Nguyen <pclouds@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	git-packagers@googlegroups.com
Subject: Re: Git v2.21.0-rc0 broken on *BSD, maybe others
Date: Wed, 13 Feb 2019 15:56:02 +0100 (STD)
Message-ID: <nycvar.QRO.7.76.6.1902131551060.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190212133032.GG1622@szeder.dev>

[-- Attachment #1: Type: text/plain, Size: 2367 bytes --]

Hi,

On Tue, 12 Feb 2019, SZEDER Gábor wrote:

> On Tue, Feb 12, 2019 at 02:14:56PM +0100, Ævar Arnfjörð Bjarmason wrote:
> > 
> > On Tue, Feb 12 2019, Duy Nguyen wrote:
> > 
> > > On Tue, Feb 12, 2019 at 7:43 PM Duy Nguyen <pclouds@gmail.com> wrote:
> > >> The test failures on NetBSD and Solaris/Sparc, not sure if we can do
> > >> anything without test logs or access to these systems.
> > >
> > > Actually if you could tweak your ci script a bit to run tests with -v,
> > > that would help.
> > 
> > I vaguely remember doing that and running into some issue where it
> > truncated the output, so e.g. I wouldn't see compile warnings on AIX
> > because of the firehose of subsequent test output.
> > 
> > But yeah, having this in some smart way would be great. I'd be most keen
> > to just work towards offloading this to some smarter test runner as
> > noted to Johannes upthread.
> > 
> > I.e. a good test_for(SHA1, params) function would run the tests with
> > "prove", and e.g. spot that tests so-and-so failed, and then run those
> > specific ones with -v -x.
> 
> Just follow suit of what we have been doing on Travis CI since the
> very beginning: run tests with '--verbose-log' to begin with, and then
> dump the logfiles of any failed tests, i.e. where the content of
> 'test-results/t1234-foo.exit' is not '0'.

Indeed, and this is how you can do it at home:

	ci/run-build-and-tests.sh || {
           ci/print-test-failures.sh
           exit 1
       }

Erm, that's how it *used* to be possible at home, but I broke that! Now it
will tell you that it "Could not identify CI type". I guess we should fix
this by introducing a new arm to the `if test true = "$TRAVIS"` construct,
to allow for manual runs (or for your CI builds where you specify the
parameters such as CI_TYPE, CI_BRANCH, CI_COMMIT and CI_OS_NAME via
environment variables).

To get you unblocked, you could rewrite ci/lib.sh on the fly:

	mv ci/lib.sh ci/lib.sh.orig
	sed "s/^if.*TRAVIS/if true; then :; el/" >ci/lib.sh <ci/lib.sh.orig

Ciao,
Dscho

> 
> Re-running a failed test is not a good idea, as it won't help if the
> test managed to fail because of a rare flakiness.
> 
> 
> > That's how I was going to fix the log overflow problem, but I'd much
> > rather not continue hacking on this gitlab-gccfarm-specific thing, and
> > instead work towards something more general.
> 

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07  7:28 [ANNOUNCE] Git v2.21.0-rc0 Junio C Hamano
2019-02-07 12:39 ` Christian Couder
2019-02-07 19:47 ` Johannes Schindelin
2019-02-07 19:50 ` Johannes Schindelin
2019-02-07 20:34   ` Junio C Hamano
2019-02-07 20:56     ` Junio C Hamano
2019-02-12 12:13 ` Git v2.21.0-rc0 broken on *BSD, maybe others Ævar Arnfjörð Bjarmason
2019-02-12 12:43   ` Duy Nguyen
2019-02-12 12:45     ` Duy Nguyen
2019-02-12 13:14       ` Ævar Arnfjörð Bjarmason
2019-02-12 13:16         ` Ævar Arnfjörð Bjarmason
2019-02-12 13:30         ` SZEDER Gábor
2019-02-13 14:56           ` Johannes Schindelin [this message]
2019-02-12 17:07     ` Junio C Hamano
2019-02-12 18:41       ` Junio C Hamano
2019-02-12 18:42       ` Junio C Hamano
2019-02-12 17:52     ` Junio C Hamano
2019-02-12 17:56       ` Junio C Hamano
2019-02-12 12:44   ` SZEDER Gábor
2019-02-12 13:07     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1902131551060.41@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git-packagers@googlegroups.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox