From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] ci: make sure we build Git parallel
Date: Fri, 8 Feb 2019 11:10:54 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1902081110310.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqh8dfmawn.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Thu, 7 Feb 2019, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >>
> >> +# Clear MAKEFLAGS that may come from the outside world.
> >> +export MAKEFLAGS=
> >> +
> >> # Set 'exit on error' for all CI scripts to let the caller know that
> >> # something went wrong.
> >> # Set tracing executed commands, primarily setting environment variables
> >> @@ -101,7 +104,7 @@ then
> >> BREW_INSTALL_PACKAGES="git-lfs gettext"
> >> export GIT_PROVE_OPTS="--timer --jobs 3 --state=failed,slow,save"
> >> export GIT_TEST_OPTS="--verbose-log -x --immediate"
> >> - export MAKEFLAGS="--jobs=2"
> >> + MAKEFLAGS="$MAKEFLAGS --jobs=2"
> >> elif test -n "$SYSTEM_COLLECTIONURI" || test -n "$SYSTEM_TASKDEFINITIONSURI"
> >> then
> >> CI_TYPE=azure-pipelines
> >> @@ -126,7 +129,7 @@ then
> >> BREW_INSTALL_PACKAGES=gcc@8
> >> export GIT_PROVE_OPTS="--timer --jobs 10 --state=failed,slow,save"
> >> export GIT_TEST_OPTS="--verbose-log -x --write-junit-xml"
> >> - export MAKEFLAGS="--jobs=10"
> >> + MAKEFLAGS="$MAKEFLAGS --jobs=10"
> >> test windows_nt != "$CI_OS_NAME" ||
> >> GIT_TEST_OPTS="--no-chain-lint --no-bin-wrappers $GIT_TEST_OPTS"
> >> else
> >> @@ -185,4 +188,4 @@ GIT_TEST_GETTEXT_POISON)
> >> ;;
> >> esac
> >>
> >> -export MAKEFLAGS="$MAKEFLAGS CC=${CC:-cc}"
> >> +MAKEFLAGS="$MAKEFLAGS CC=${CC:-cc}"
> >
> > Since this is intended to be run in a CI setting, there is not a whole lot
> > of opportunity to set `MAKEFLAGS` outside of the script. And if there is,
> > that might open a rabbit hole when debugging issues that somehow in the
> > end turn out to come from a hard-coded `MAKEFLAGS` somewhere in the CI
> > system.
> >
> > So I'd rather clear `MAKEFLAGS` at the beginning (i.e. where you `export
> > MAKEFLAGS`, I'd simply append a `=`).
>
> I meant to clear it at the beginning, where I "export MAKEFLAGS=".
> Did your MUA ate the equal sign at the end, mistaking it with part
> of text/plain; format=flawed or something?
I could have sworn that there was no equal sign yesterday.
Sorry for the noise,
Dscho
next prev parent reply other threads:[~2019-02-08 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:37 [PATCH] ci: make sure we build Git parallel SZEDER Gábor
2019-02-07 19:00 ` Junio C Hamano
2019-02-07 19:04 ` Junio C Hamano
2019-02-07 19:35 ` Junio C Hamano
2019-02-07 22:32 ` Johannes Schindelin
2019-02-07 23:33 ` Junio C Hamano
2019-02-07 23:45 ` [PATCH] ci: clear and mark MAKEFLAGS exported just once Junio C Hamano
2019-02-08 0:17 ` SZEDER Gábor
2019-02-08 10:11 ` Johannes Schindelin
2019-02-08 10:10 ` Johannes Schindelin [this message]
2019-02-08 17:25 ` [PATCH] ci: make sure we build Git parallel Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1902081110310.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).