* [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting
@ 2019-02-05 2:25 Ramsay Jones
2019-02-05 11:26 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2019-02-05 2:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Johannes Schindelin, GIT Mailing-list, Luc Van Oostenryck
An upcoming commit will change the semantics of the SPARSE_FLAGS
variable from an internal to a user only customisation variable.
The MinGW configuration section contains an obsolete setting for
this variable which was used (some years ago) to cater to an error
in the Win32 system header files. Since 'sparse' does not currently
support the MinGW platform, nobody on that platform can be relying
on this setting today. Remove this use of the SPARSE_FLAGS variable.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
config.mak.uname | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname
index 7b36a1dfe7..786bb2f913 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
RC = windres -O coff
NATIVE_CRLF = YesPlease
X = .exe
- SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
htmldir = doc/git/html/
prefix =
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting
2019-02-05 2:25 [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting Ramsay Jones
@ 2019-02-05 11:26 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2019-02-05 11:26 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list, Luc Van Oostenryck
Hi Ramsay,
On Tue, 5 Feb 2019, Ramsay Jones wrote:
>
> An upcoming commit will change the semantics of the SPARSE_FLAGS
> variable from an internal to a user only customisation variable.
> The MinGW configuration section contains an obsolete setting for
> this variable which was used (some years ago) to cater to an error
> in the Win32 system header files. Since 'sparse' does not currently
> support the MinGW platform, nobody on that platform can be relying
> on this setting today. Remove this use of the SPARSE_FLAGS variable.
ACK,
Dscho
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> config.mak.uname | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 7b36a1dfe7..786bb2f913 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
> RC = windres -O coff
> NATIVE_CRLF = YesPlease
> X = .exe
> - SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
> ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
> htmldir = doc/git/html/
> prefix =
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-05 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 2:25 [PATCH v2 1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting Ramsay Jones
2019-02-05 11:26 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).