From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: William Hubbs <williamh@gentoo.org>,
git@vger.kernel.org, chutzpah@gentoo.org
Subject: Re: [PATCH v3 1/1] config: allow giving separate author and committer idents
Date: Mon, 4 Feb 2019 13:17:35 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1902041314160.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqfttb599s.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Tue, 29 Jan 2019, Junio C Hamano wrote:
> William Hubbs <williamh@gentoo.org> writes:
>
> > diff --git a/cache.h b/cache.h
> > index 009e8b3b15..375be1f68b 100644
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -1494,10 +1494,19 @@ int date_overflows(timestamp_t date);
> > #define IDENT_STRICT 1
> > #define IDENT_NO_DATE 2
> > #define IDENT_NO_NAME 4
> > +
> > +enum want_ident {
> > + WANT_BLANK_IDENT,
> > + WANT_AUTHOR_IDENT,
> > + WANT_COMMITTER_IDENT,
>
> I do not recall we crossed the bridge to allow trailing comma here
> at the end of enum definition.
In advice.c:
enum color_advice {
ADVICE_COLOR_RESET = 0,
ADVICE_COLOR_HINT = 1,
};
In builtin/pack-objects.c:
enum missing_action {
MA_ERROR = 0, /* fail if any missing objects are encountered */
MA_ALLOW_ANY, /* silently allow ALL missing objects */
MA_ALLOW_PROMISOR, /* silently allow all missing PROMISOR objects */
};
In builtin/rev-list.c:
enum missing_action {
MA_ERROR = 0, /* fail if any missing objects are encountered */
MA_ALLOW_ANY, /* silently allow ALL missing objects */
MA_PRINT, /* print ALL missing objects in special section */
MA_ALLOW_PROMISOR, /* silently allow all missing PROMISOR objects */
};
... and I will stop here. You are correct that the majority of our enums
does not let its last item end in a comma. But we did cross that bridge.
Ciao,
Dscho
next prev parent reply other threads:[~2019-02-04 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 23:08 [PATCH v3 0/1] config: allow giving different author and committer idents William Hubbs
2019-01-29 23:08 ` [PATCH v3 1/1] config: allow giving separate " William Hubbs
2019-01-29 23:33 ` Junio C Hamano
2019-02-04 12:17 ` Johannes Schindelin [this message]
2019-02-04 18:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1902041314160.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=chutzpah@gentoo.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=williamh@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).