From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthew Kraai via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>,
Matthew Kraai <mkraai@its.jnj.com>
Subject: Re: [PATCH 1/1] stash: fix segmentation fault when files were added with intent
Date: Wed, 23 Jan 2019 12:38:02 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1901231236060.45@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqd0ooh79n.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Tue, 22 Jan 2019, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > when I want to see whether a given branch is buggy and when I cannot
> > simply `git cherry-pick <commit-demonstrating-a-bug>`:
> >
> > git cherry-pick <commit-fixing-the-bug-and-adding-a-test>
> > git checkout HEAD^ -- :^/t/
>
> Yup. It is easy to just apply the t/ part to grab the test update
> to see breakage (which I already said when I told you to have a fix
> and test protecting the future breakage of the fix in a single patch
> long time ago).
Sorry, that was not my point.
My point is that
git cherry-pick <commit-fixing-the-bug-and-adding-a-test>
git checkout HEAD^ -- :^/t/
is *ridiculously* less intuitive than
git cherry-pick <commit-demonstrating-a-bug>
and I would rather you stop promoting the former over the latter. After
all, Git's purpose in life is to make things easier and quicker and less
error-prone, rathern than slower, more complicated and unintuitive.
And I am sure you agree with me on that goal, so I do not understand why
you promote that a bit more.
Ciao,
Dscho
prev parent reply other threads:[~2019-01-23 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:50 [PATCH 0/1] built-in stash: fix segmentation fault when files were added with intent Johannes Schindelin via GitGitGadget
2019-01-18 9:50 ` [PATCH 1/1] " Matthew Kraai via GitGitGadget
2019-01-18 20:42 ` Junio C Hamano
2019-01-21 15:14 ` Johannes Schindelin
2019-01-22 18:33 ` Junio C Hamano
2019-01-23 11:38 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1901231236060.45@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=mkraai@its.jnj.com \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).