git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: William Hubbs <williamh@gentoo.org>
Cc: git@vger.kernel.org, chutzpah@gentoo.org
Subject: Re: [PATCH 1/1]     Add author and committer configuration settings
Date: Fri, 21 Dec 2018 13:15:40 +0100 (STD)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1812211310040.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20181219183939.16358-2-williamh@gentoo.org>

Hi William,

thank you for putting this together.

On Wed, 19 Dec 2018, William Hubbs wrote:

> -extern const char *fmt_name(const char *name, const char *email);
> +extern const char *fmt_committer_name(void);

If it would not be too much trouble for you, could I ask you to split this
change out into a separate commit (which would be the first of now two
patches)? It could have a commit message like this:

	ident: rename fmt_name() to fmt_committer_name()

	Ever since 4c28e4ada03f (commit: die before asking to edit the log
	message, 2010-12-20), all remaining callers of that function want
	to format the committer name. To simplify the code, therefore, we
	rename the function and move the getenv() call into it.

Ciao,
Dscho

  parent reply	other threads:[~2018-12-21 12:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 18:39 [PATCH 0/1] add author and committer configuration settings William Hubbs
2018-12-19 18:39 ` [PATCH 1/1] Add " William Hubbs
2018-12-19 20:05   ` John Passaro
2018-12-21 12:15   ` Johannes Schindelin [this message]
2019-01-02 22:57   ` Junio C Hamano
2018-12-19 21:46 ` [PATCH 0/1] add " Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1812211310040.41@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=chutzpah@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=williamh@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).