git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Andrew Kharchenko <andrew.kharchenko@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Pre-commit hook does not work properly in recent version
Date: Thu, 13 Dec 2018 20:19:01 +0100 (STD)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1812132018170.43@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <678FE577-1708-4B7A-8EE6-EBE2514A4D04@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Andrew,

On Thu, 13 Dec 2018, Andrew Kharchenko wrote:

> I found a bug in Git v. 2.20.0 and 2.19.x at least, where pre-commit hook does not work properly.
> 
> OS: macOS High Sierra
> Git: 2.20.0, 2.19.x
> 
> Description: pre-commit file should be marked as executable in order to recreate the bug. When executing “git commit”, it silently exits without any message.
> It was found, that Git version 2.17.1 still works as expected.

Have you dug deeper? Like, add a `set -x` at the beginning of that hook to
find out why it is exiting early?

Ciao,
Johannes

      reply	other threads:[~2018-12-13 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 15:03 Pre-commit hook does not work properly in recent version Andrew Kharchenko
2018-12-13 19:19 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1812132018170.43@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=andrew.kharchenko@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).