From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] .gitattributes: ensure t/oid-info/* has eol=lf
Date: Thu, 13 Dec 2018 14:44:16 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1812131443500.43@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20181213132254.GW30222@szeder.dev>
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
Hi Gábor,
On Thu, 13 Dec 2018, SZEDER Gábor wrote:
> On Thu, Dec 13, 2018 at 02:01:15PM +0100, Johannes Schindelin wrote:
> >
> > On Wed, 12 Dec 2018, SZEDER Gábor wrote:
> >
> > > On Tue, Dec 11, 2018 at 12:35:46PM -0800, Derrick Stolee via GitGitGadget wrote:
> > > > From: Derrick Stolee <dstolee@microsoft.com>
> > > >
> > > > The new test_oid machinery in the test library requires reading
> > > > some information from t/oid-info/hash-info and t/oid-info/oid.
> > > > The shell logic that reads from these files is sensitive to CRLF
> > > > line endings, causing a problem when the test suite is run on a
> > > > Windows machine that converts LF to CRLF.
> > >
> > > "What problem?" is what people will ask when they read this commit
> > > message in the future.
> >
> > The test script (not test case) fails with the rather terrifying message
> >
> > error: bug in the test script: bad hash algorithm
> >
> > See e.g. line 958 of the Build & Test log in the Windows phase of
> > https://dev.azure.com/git-for-windows/git/_build/results?buildId=26757
>
> Yeah, I saw that in the cover letter. And that was my point, that I
> saw this there, not in the proposed commit log message:
>
> > > Please include the relevant details in the commit message instead of
> > > the cover letter.
Oy, oy, oy. I missed that. Where is the coffee.
Ciao,
Dscho
next prev parent reply other threads:[~2018-12-13 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 20:35 [PATCH 0/1] .gitattributes: ensure t/oid-info/* has eol=lf Derrick Stolee via GitGitGadget
2018-12-11 20:35 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2018-12-12 13:39 ` SZEDER Gábor
2018-12-13 13:01 ` Johannes Schindelin
2018-12-13 13:22 ` SZEDER Gábor
2018-12-13 13:44 ` Johannes Schindelin [this message]
2018-12-12 8:38 ` [PATCH 0/1] " Junio C Hamano
2018-12-12 18:14 ` [PATCH v2 0/2] Add more eol=lf to .gitattributes Derrick Stolee via GitGitGadget
2018-12-12 18:14 ` [PATCH v2 1/2] .gitattributes: ensure t/oid-info/* has eol=lf Derrick Stolee via GitGitGadget
2018-12-13 2:38 ` Junio C Hamano
2018-12-13 16:22 ` Derrick Stolee
2018-12-14 2:23 ` Junio C Hamano
2018-12-14 0:51 ` brian m. carlson
2018-12-14 11:10 ` Johannes Schindelin
2018-12-12 18:14 ` [PATCH v2 2/2] t4256: mark support files as LF-only Johannes Schindelin via GitGitGadget
2018-12-13 2:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1812131443500.43@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).