From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 8010D20A1E for ; Tue, 11 Dec 2018 13:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726454AbeLKN2q (ORCPT ); Tue, 11 Dec 2018 08:28:46 -0500 Received: from mout.gmx.net ([212.227.15.18]:39543 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbeLKN2q (ORCPT ); Tue, 11 Dec 2018 08:28:46 -0500 Received: from [192.168.0.129] ([37.201.193.149]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MPDaC-1gb5oJ3w5A-004Utd; Tue, 11 Dec 2018 14:28:44 +0100 Date: Tue, 11 Dec 2018 14:28:43 +0100 (STD) From: Johannes Schindelin X-X-Sender: virtualbox@gitforwindows.org To: =?UTF-8?Q?Torsten_B=C3=B6gershausen?= cc: git@vger.kernel.org, svnpenn@gmail.com Subject: Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again) In-Reply-To: <20181211061204.GA1130@tor.lan> Message-ID: References: <5bf18396.1c69fb81.20780.2b1d@mx.google.com> <20181208151109.2097-1-tboegi@web.de> <20181211061204.GA1130@tor.lan> User-Agent: Alpine 2.21.1 (DEB 209 2017-03-23) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-711551677-1544534924=:43" X-Provags-ID: V03:K1:cppR38N8iyeGDHIR98vpoMowcvFcYfZ6iF7sRBDIOveZHkYMoE3 ViYhhSv39iykWwZaXLFItThv1nsAmMZW/YTAh22P9DwzWFBC0CJqcETORpQRHXdJQlvewR2 VEeYRRRFl061jFkV5XmoQIJdhvP49MmHkjEKmqlkp3SWu2JLU5jPHHpaFEZ/xNXfReQs7IO FbVkZEnwYQw16dbZQde+A== X-UI-Out-Filterresults: notjunk:1;V03:K0:6xfyYr5iDls=:MLyg4PHKxrt8bhM+lOI9Fn OG6SZi0oxBTaFlbZIC+OrRPrvEQT5sVWgchelWgTcjt0gTiSdgNZX2O5Tqgx7Pi4s5FrY1sMC AR+yOni/hZjlvvyMhJq4u1LSEYWnHjkDnCdUPJx5ptjHlg33DBATquLJxATIGjCoJkPdfunw3 3zAzxXGk4igVHbdxyxfPaG4xJ6h9IWNmi0SXEE/5KxRmtN0BEiNXwXYJgzMcE13vP7rCYKLYz 4sxC4DLyzLcyGBazbjqVpb2j6aoQOL65gdC51JIOAlQvo7qnJgvC2TeBFjuoz87h0IQxDypYY 9NkabRdYW3YkRbZIxhulIMQYo4eQb+4E4r17bnHn6tn76GfUu4vdks9NeLMhmMaxAigztg5kE JPT8n4BOXFyu76oyrrzRYLWpD0vGNGL7g4UVxy0AkFMgg2Roes8sh+YO467QXPUJEzPrtWM1p RzIq9FsXSzfZX4YLB4urm6HlQyb3lC2SaufOLGrQNGFuWfpqOSr+Z8PLR5hOWgH3qdzrs1EPB pwxhf/mX7hdXZQ6YnIVa4dgZgP3PR3FUWvRGnBJt2JXqY9rUinsyxbtrrBIGcEVv5h0cjc+wo KQ2RYgtma6SoBmOvixkHYFzXDYa41ouFa462fLTF8rJY0wtnmZ2JvHPXoFJ7m6VzUo1NT46r/ mMNrcHCerqa3D06NNuWkLVD1cYsohrUtKElOwBdV6tHFej+qLS6q7h45AMFz7kZa03casAfWr yo4zfe+xcs9d9KxeI6KjVcDueMNgnjfCXJ8y0cpIJs6JJ8XtQXSsQoatJnmMsWtEps+VXzEt4 12/xzoNus6hzCwRjtanYtzkMZDYtWw44QwoKvihg7d0OWSa/LpJ4psOCN+NPQbK4Pwztgjd/9 leAkXmiwu9UDu6K8WWBK/IwHOK8KLJo7pT7bJ/ATWhOsAJakzWkaXCtmD15H5TNGfQpW/DwoT XRTYKTOkX5w== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-711551677-1544534924=:43 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hi Torsten, On Tue, 11 Dec 2018, Torsten Bögershausen wrote: > On Mon, Dec 10, 2018 at 09:32:03AM +0100, Johannes Schindelin wrote: > > > > On Sat, 8 Dec 2018, tboegi@web.de wrote: > > > > > And, before any cleanup is done, I sould like to ask if anybody > > > can build the code with VS and confirm that it works, please ? > > > > Can you give me an easy-to-fetch branch? > > > > Thanks, > > Dscho > > @Dscho: The branch should be here: > https://github.com/tboegi/git/tree/tb.181208_0844_cygwin-dos-drive > (or fetch it from Junio, please see below:) I fetched it from you, as Junio frequently applies patches anywhere except where they were developed. I'd rather see what you see. For the record, this is the commit I tested: cc1e08eeb83b. It builds fine here, and some cursory tests reveal that it works as advertised (I ran t0001, t0060 and t5580). However. Can you please replace the rather unnecessary, very, very long `win_path_utils_` function name prefix by the much better prefix `win32_`, to keep in line with the current, already existing, surrounding files' convention? Thanks a bunch. Ciao, Dscho > @Junio: > Please keep tb/use-common-win32-pathfuncs-on-cygwin > in pu for a while. I need to send a V4 to fix t5601 for cygwin. > > --8323328-711551677-1544534924=:43--