From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "H.Merijn Brand" <h.m.brand@xs4all.nl>, git@vger.kernel.org
Subject: Re: in 2.19.2 t0061-run-command FAILs if . is in $PATH
Date: Thu, 29 Nov 2018 11:13:39 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1811291112460.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqpnuor6qs.fsf@gitster-ct.c.googlers.com>
Hi Merijn and Junio,
On Thu, 29 Nov 2018, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > -test_expect_success 'run_command is restricted to PATH' '
> > +test_lazy_prereq DOT_IN_PATH '
> > + case ":$PATH:" in
> > + *:.:*) true;;
> > + *) false;;
> > + esac
> > +'
>
> An empty element in the colon-separated list also serves as an
> instruction to pick up executable from $cwd, so
>
> case ":$PATH:" in
> *:.:** | *::*) true ;;
> *) false ;;
> esac
>
> perhaps.
Good point.
Merijn, please be sure to squash this fix in before you submit the final
thing.
Thanks,
Johannes
>
> > +test_expect_success !DOT_IN_PATH 'run_command is restricted to PATH' '
> > write_script should-not-run <<-\EOF &&
> > echo yikes
> > EOF
> > -- snap --
> >
> > If so, can you please provide a commit message for it (you can add my
> > Signed-off-by: line and your Tested-by: line).
> >
> > Thanks,
> > Johannes
>
prev parent reply other threads:[~2018-11-29 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:05 in 2.19.2 t0061-run-command FAILs if . is in $PATH H.Merijn Brand
2018-11-28 9:42 ` Johannes Schindelin
2018-11-29 1:51 ` Junio C Hamano
2018-11-29 10:13 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1811291112460.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=h.m.brand@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).