From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Slavica Djukic <slavicadj.ip2018@gmail.com>
Cc: git@vger.kernel.org, slawica92@hotmail.com
Subject: Re: [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email
Date: Thu, 15 Nov 2018 13:37:06 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1811151336330.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20181114222524.2624-1-slawica92@hotmail.com>
Hi Slavica,
this looks very good to me. Just one grammar thing:
On Wed, 14 Nov 2018, Slavica Djukic wrote:
> Add test to document that stash fails if user.name and user.email
> are not configured.
> In the later commit, test will be updated to expect success.
In a later commit [...]
Otherwise, I would be totally fine with this version being merged.
Ciao,
Johannes
>
> Signed-off-by: Slavica Djukic <slawica92@hotmail.com>
> ---
> t/t3903-stash.sh | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index cd216655b..bab8bec67 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -1096,4 +1096,27 @@ test_expect_success 'stash -- <subdir> works with binary files' '
> test_path_is_file subdir/untracked
> '
>
> +test_expect_failure 'stash works when user.name and user.email are not set' '
> + git reset &&
> + git var GIT_COMMITTER_IDENT >expected &&
> + >1 &&
> + git add 1 &&
> + git stash &&
> + git var GIT_COMMITTER_IDENT >actual &&
> + test_cmp expected actual &&
> + >2 &&
> + git add 2 &&
> + test_config user.useconfigonly true &&
> + test_config stash.usebuiltin true &&
> + (
> + sane_unset GIT_AUTHOR_NAME &&
> + sane_unset GIT_AUTHOR_EMAIL &&
> + sane_unset GIT_COMMITTER_NAME &&
> + sane_unset GIT_COMMITTER_EMAIL &&
> + test_unconfig user.email &&
> + test_unconfig user.name &&
> + git stash
> + )
> +'
> +
> test_done
> --
> 2.19.1.1052.gd166e6afe
>
>
next prev parent reply other threads:[~2018-11-15 12:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 16:29 [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name Slavica
2018-10-23 18:52 ` Christian Couder
2018-10-24 13:56 ` Slavica
2018-10-25 4:44 ` Junio C Hamano
2018-10-23 19:19 ` Eric Sunshine
2018-10-24 2:48 ` Junio C Hamano
2018-10-24 7:39 ` Johannes Schindelin
2018-10-24 9:58 ` Junio C Hamano
2018-10-24 15:18 ` Johannes Schindelin
2018-10-25 4:17 ` Junio C Hamano
2018-10-24 20:01 ` [PATCH v2 " Slavica Djukic
2018-10-24 20:05 ` Slavica Djukic
2018-10-24 20:25 ` Eric Sunshine
2018-10-25 4:48 ` Junio C Hamano
2018-10-25 19:13 ` [PATCH v3 " Slavica Djukic
2018-10-25 19:20 ` Slavica Djukic
2018-10-26 1:13 ` Junio C Hamano
2018-10-30 13:04 ` Slavica Djukic
2018-11-01 11:55 ` [PATCH 0/3] [Outreachy] make stash work if user.name and user.email are not configured Slavica Djukic
2018-11-01 11:58 ` [PATCH 1/3][Outreachy] t3903-stash: test without configured user.name and user.email Slavica Djukic
2018-11-01 14:53 ` Christian Couder
2018-11-02 4:59 ` [PATCH 2+3/3] stash: tolerate missing user identity Junio C Hamano
2018-11-01 12:00 ` [PATCH 2/3] [Outreachy] ident: introduce set_fallback_ident() function Slavica Djukic
2018-11-02 3:01 ` Junio C Hamano
2018-11-02 4:41 ` Junio C Hamano
2018-11-02 5:22 ` Junio C Hamano
2018-11-01 12:02 ` [PATCH 3/3] [Outreachy] stash: use " Slavica Djukic
2018-11-14 22:12 ` [PATCH v2 0/2] [Outreachy] make stash work if user.name and user.email are not configured Slavica Djukic
2018-11-14 22:25 ` [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email Slavica Djukic
2018-11-15 12:37 ` Johannes Schindelin [this message]
2018-11-16 5:55 ` Junio C Hamano
2018-11-16 6:26 ` Junio C Hamano
2018-11-16 6:32 ` Junio C Hamano
2018-11-16 8:28 ` Slavica Djukic
2018-11-16 10:12 ` Junio C Hamano
2018-11-17 18:47 ` Slavica Djukic
2018-11-18 6:28 ` Junio C Hamano
2018-11-14 22:28 ` [PATCH v2 2/2] [Outreachy] stash: tolerate missing user identity Slavica Djukic
2018-11-16 5:35 ` Junio C Hamano
2018-11-18 13:29 ` [PATCH 0/1 v3] make stash work if user.name and user.email are not configured Slavica Djukic
2018-11-18 13:44 ` [PATCH 1/1 v3] stash: tolerate missing user identity Slavica Djukic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1811151336330.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=slavicadj.ip2018@gmail.com \
--cc=slawica92@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).