* [PATCH] travis-ci: no longer use containers @ 2018-10-25 17:41 Sebastian Staudt 2018-10-26 0:09 ` Junio C Hamano 0 siblings, 1 reply; 9+ messages in thread From: Sebastian Staudt @ 2018-10-25 17:41 UTC (permalink / raw) To: git Travis CI will soon deprecate the container-based infrastructure enabled by `sudo: false` in ce59dffb34190e780be2fa9f449f842cadee9753. More info: https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures Signed-off-by: Sebastian Staudt <koraktor@gmail.com> --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 4d4e26c9df..8d2499739e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,5 @@ language: c -sudo: false - cache: directories: - $HOME/travis-cache -- 2.19.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: no longer use containers 2018-10-25 17:41 [PATCH] travis-ci: no longer use containers Sebastian Staudt @ 2018-10-26 0:09 ` Junio C Hamano 2018-10-26 1:39 ` SZEDER Gábor 2018-10-26 5:06 ` [PATCH] travis-ci: no longer use containers Sebastian Staudt 0 siblings, 2 replies; 9+ messages in thread From: Junio C Hamano @ 2018-10-26 0:09 UTC (permalink / raw) To: Lars Schneider, SZEDER Gábor, Sebastian Staudt; +Cc: git Sebastian Staudt <koraktor@gmail.com> writes: > Travis CI will soon deprecate the container-based infrastructure > enabled by `sudo: false` in ce59dffb34190e780be2fa9f449f842cadee9753. > > More info: > https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures Thanks for posting a patch that would serve as a good discussion starter. This is not a criticism on your patch, but more is a RFD to those who helped our use of Travis by contributing to .travis.yml and ci/. Don't we need to do some other things so that we can run in vm environment, rather than in container environment, before doing this change? IOW, aren't we doing in .travis.yml something we can do only in container but not in vm (if there is any), and if so, shouldn't we be rewriting that something so that we can run in vm? I know ce59dffb ("travis-ci: explicity use container-based infrastructure", 2016-01-26) only added "sudo: false" without doing anything else (e.g. adding things that are only available to those who run in container), but if we added stuff that are not usable in vm environment after that commit since then, we need to adjust them so that we can migrate to the container-based environment, no? To me, removing that "sudo: false" line seems like the least thing we need to worry about. After all, they say that whether we have "sudo: false" or not, the CI jobs will start running in vm environment and not in container. So if the rest of .travis.yml is ready to run in vm environment, we do not have to do anything ;-). In short, my question to Lars and SZEDER is, are we already prepared to be thrown into a vm environment? If the answer is "yes", then I think removing "sudo: false" is probably still a good thing to do for documentation purposes (i.e. showing that we knew we are ready to go through their migration). Thanks. > Signed-off-by: Sebastian Staudt <koraktor@gmail.com> > --- > .travis.yml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 4d4e26c9df..8d2499739e 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -1,7 +1,5 @@ > language: c > > -sudo: false > - > cache: > directories: > - $HOME/travis-cache > -- > 2.19.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: no longer use containers 2018-10-26 0:09 ` Junio C Hamano @ 2018-10-26 1:39 ` SZEDER Gábor 2018-11-01 11:47 ` [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' SZEDER Gábor 2018-10-26 5:06 ` [PATCH] travis-ci: no longer use containers Sebastian Staudt 1 sibling, 1 reply; 9+ messages in thread From: SZEDER Gábor @ 2018-10-26 1:39 UTC (permalink / raw) To: Junio C Hamano; +Cc: Lars Schneider, Sebastian Staudt, git On Fri, Oct 26, 2018 at 09:09:48AM +0900, Junio C Hamano wrote: > Sebastian Staudt <koraktor@gmail.com> writes: > > > Travis CI will soon deprecate the container-based infrastructure > > enabled by `sudo: false` in ce59dffb34190e780be2fa9f449f842cadee9753. > > > > More info: > > https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures > > Thanks for posting a patch that would serve as a good discussion > starter. This is not a criticism on your patch, but more is a RFD > to those who helped our use of Travis by contributing to .travis.yml > and ci/. > > Don't we need to do some other things so that we can run in vm > environment, rather than in container environment, before doing this > change? IOW, aren't we doing in .travis.yml something we can do > only in container but not in vm (if there is any), and if so, > shouldn't we be rewriting that something so that we can run in vm? As far as I understand, the container-based infrastructure has only one benefit over the VMs, the shorter startup time. OTOH, in VMs we can use sudo, which is not available in the container-based intra. This has the benefit that after switching to VMs, we'll be able to install packages by running 'sudo apt-get install ...'. Currently the necessary packages are listed in '.travis.yml' for Travis CI, while for Azure the whole install command is embedded in '.azure....yml'. After the switch we could consolidate installing packages by 'sudo apt-get...' in 'ci/install-dependencies.sh' for both. > I know ce59dffb ("travis-ci: explicity use container-based > infrastructure", 2016-01-26) only added "sudo: false" without doing > anything else (e.g. adding things that are only available to those > who run in container), but if we added stuff that are not usable in > vm environment after that commit since then, we need to adjust them > so that we can migrate to the container-based environment, no? > > To me, removing that "sudo: false" line seems like the least thing > we need to worry about. After all, they say that whether we have > "sudo: false" or not, the CI jobs will start running in vm > environment and not in container. So if the rest of .travis.yml is > ready to run in vm environment, we do not have to do anything ;-). > > In short, my question to Lars and SZEDER is, are we already prepared > to be thrown into a vm environment? I think we are. I've run only two builds with this patch, and they run smoothly and finished successfully. After you update 'pu' I'll run more. > If the answer is "yes", then I think removing "sudo: false" is > probably still a good thing to do for documentation purposes > (i.e. showing that we knew we are ready to go through their > migration). I agree. > > Signed-off-by: Sebastian Staudt <koraktor@gmail.com> > > --- > > .travis.yml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 4d4e26c9df..8d2499739e 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -1,7 +1,5 @@ > > language: c > > > > -sudo: false > > - > > cache: > > directories: > > - $HOME/travis-cache > > -- > > 2.19.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' 2018-10-26 1:39 ` SZEDER Gábor @ 2018-11-01 11:47 ` SZEDER Gábor 2018-11-02 2:25 ` Junio C Hamano 0 siblings, 1 reply; 9+ messages in thread From: SZEDER Gábor @ 2018-11-01 11:47 UTC (permalink / raw) To: Junio C Hamano Cc: Johannes Schindelin, Lars Schneider, Sebastian Staudt, git, SZEDER Gábor Ever since we started using Travis CI, we specified the list of packages to install in '.travis.yml' via the APT addon. While running our builds on Travis CI's container-based infrastructure we didn't have another choice, because that environment didn't support 'sudo', and thus we didn't have permission to install packages ourselves. With the switch to the VM-based infrastructure in the previous patch we do get a working 'sudo', so we can install packages by running 'sudo apt-get -y install ...' as well. Let's make use of this and install necessary packages in 'ci/install-dependencies.sh', so all the dependencies (i.e. both packages and "non-packages" (P4 and Git-LFS)) are handled in the same file. Install gcc-8 only in the 'linux-gcc' build job; so far it has been unnecessarily installed in the 'linux-clang' build job as well. Print the versions of P4 and Git-LFS conditionally, i.e. only when they have been installed; with this change even the static analysis and documentation build jobs start using 'ci/install-dependencies.sh' to install packages, and neither of these two build jobs depend on and thus install those. This change will presumably be beneficial for the upcoming Azure Pipelines integration [1]: preliminary versions of that patch series run a couple of 'apt-get' commands to install the necessary packages before running 'ci/install-dependencies.sh', but with this patch it will be sufficient to run only 'ci/install-dependencies.sh'. [1] https://public-inbox.org/git/1a22efe849d6da79f2c639c62a1483361a130238.1539598316.git.gitgitgadget@gmail.com/ Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- This patch should go on top of 'ss/travis-ci-force-vm-mode'. I'm not sure about the last paragraph, because: - It talks about presumed benefits for a currently still work-in-progress patch series of an other contributor, and I'm not really sure that that's a good thing. Perhaps I should have rather put it below the '---'. - I'm confused about the name of this Azure thing. The cover letter mentions "Azure Pipelines", the file is called 'azure-pipelines.yml', but the relevant patch I link to talks about "Azure DevOps" in the commit message. Anyway, keep that last paragraph or drop it as you see fit. .travis.yml | 21 --------------------- ci/install-dependencies.sh | 35 +++++++++++++++++++++++++++++------ 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8d2499739e..a5a82d6832 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,16 +12,6 @@ compiler: - clang - gcc -addons: - apt: - sources: - - ubuntu-toolchain-r-test - packages: - - language-pack-is - - git-svn - - apache2 - - gcc-8 - matrix: include: - env: jobname=GETTEXT_POISON @@ -50,22 +40,11 @@ matrix: - env: jobname=StaticAnalysis os: linux compiler: - addons: - apt: - packages: - - coccinelle - before_install: script: ci/run-static-analysis.sh after_failure: - env: jobname=Documentation os: linux compiler: - addons: - apt: - packages: - - asciidoc - - xmlto - before_install: script: ci/test-documentation.sh after_failure: diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index 75a9fd2475..06c3546e1e 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -10,6 +10,15 @@ LFSWHENCE=https://github.com/github/git-lfs/releases/download/v$LINUX_GIT_LFS_VE case "$jobname" in linux-clang|linux-gcc) + sudo apt-add-repository -y "ppa:ubuntu-toolchain-r/test" + sudo apt-get -q update + sudo apt-get -q -y install language-pack-is git-svn apache2 + case "$jobname" in + linux-gcc) + sudo apt-get -q -y install gcc-8 + ;; + esac + mkdir --parents "$P4_PATH" pushd "$P4_PATH" wget --quiet "$P4WHENCE/bin.linux26x86_64/p4d" @@ -32,11 +41,25 @@ osx-clang|osx-gcc) brew link --force gettext brew install caskroom/cask/perforce ;; +StaticAnalysis) + sudo apt-get -q update + sudo apt-get -q -y install coccinelle + ;; +Documentation) + sudo apt-get -q update + sudo apt-get -q -y install asciidoc xmlto + ;; esac -echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)" -p4d -V | grep Rev. -echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)" -p4 -V | grep Rev. -echo "$(tput setaf 6)Git-LFS Version$(tput sgr0)" -git-lfs version +if type p4d >/dev/null && type p4 >/dev/null +then + echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)" + p4d -V | grep Rev. + echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)" + p4 -V | grep Rev. +fi +if type git-lfs >/dev/null +then + echo "$(tput setaf 6)Git-LFS Version$(tput sgr0)" + git-lfs version +fi -- 2.19.1.838.g101e68a972 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' 2018-11-01 11:47 ` [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' SZEDER Gábor @ 2018-11-02 2:25 ` Junio C Hamano 2018-11-08 21:51 ` SZEDER Gábor 0 siblings, 1 reply; 9+ messages in thread From: Junio C Hamano @ 2018-11-02 2:25 UTC (permalink / raw) To: SZEDER Gábor Cc: Johannes Schindelin, Lars Schneider, Sebastian Staudt, git SZEDER Gábor <szeder.dev@gmail.com> writes: > Ever since we started using Travis CI, we specified the list of > packages to install in '.travis.yml' via the APT addon. While running > our builds on Travis CI's container-based infrastructure we didn't > have another choice, because that environment didn't support 'sudo', > and thus we didn't have permission to install packages ourselves. With > the switch to the VM-based infrastructure in the previous patch we do > get a working 'sudo', so we can install packages by running 'sudo > apt-get -y install ...' as well. OK, so far we learned that this is now _doable_; but not enough to decide if this is a good thing to do or not. Let's read on to find out. > Let's make use of this and install necessary packages in > 'ci/install-dependencies.sh', so all the dependencies (i.e. both > packages and "non-packages" (P4 and Git-LFS)) are handled in the same > file. So we used to have two waysto prepare the test environment; non packaged software were done via install-dependencies.sh, but packaged ones weren't. Unifying them so that the script installs both would be a good change to simplify the procedure. Is that how this sentence argues for this change? > Install gcc-8 only in the 'linux-gcc' build job; so far it has > been unnecessarily installed in the 'linux-clang' build job as well. Is this "unneeded gcc-8 was installed" something we can fix only because we now stopped doing the installation via apt addon? Or we could have fixed it while we were on apt addon but we didn't bother, and this patch fixes it "while at it"---primarily because the shell script is far more flexible to work with than travis.yml matrix and this kind of customization is far easier to do? > Print the versions of P4 and Git-LFS conditionally, i.e. only when > they have been installed; with this change even the static analysis > and documentation build jobs start using 'ci/install-dependencies.sh' > to install packages, and neither of these two build jobs depend on and > thus install those. > > This change will presumably be beneficial for the upcoming Azure > Pipelines integration [1]: preliminary versions of that patch series > run a couple of 'apt-get' commands to install the necessary packages > before running 'ci/install-dependencies.sh', but with this patch it > will be sufficient to run only 'ci/install-dependencies.sh'. So the main point of this change is to have less knowledge to prepare the target configuration in the .travis.yml file and keep them all in ci/install-dependencies.sh, which hopefully is more reusable than .travis.yml in a non Travis environment? If that is the case, it makes sense to me. > This patch should go on top of 'ss/travis-ci-force-vm-mode'. > > I'm not sure about the last paragraph, because: > > - It talks about presumed benefits for a currently still > work-in-progress patch series of an other contributor, and I'm not > really sure that that's a good thing. Perhaps I should have > rather put it below the '---'. > > - I'm confused about the name of this Azure thing. The cover letter > mentions "Azure Pipelines", the file is called > 'azure-pipelines.yml', but the relevant patch I link to talks > about "Azure DevOps" in the commit message. > > Anyway, keep that last paragraph or drop it as you see fit. I hope we'll hear from Dscho in one or two revolutions of the Earth ;-) > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index 75a9fd2475..06c3546e1e 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -10,6 +10,15 @@ LFSWHENCE=https://github.com/github/git-lfs/releases/download/v$LINUX_GIT_LFS_VE > > case "$jobname" in > linux-clang|linux-gcc) > + sudo apt-add-repository -y "ppa:ubuntu-toolchain-r/test" > + sudo apt-get -q update > + sudo apt-get -q -y install language-pack-is git-svn apache2 > + case "$jobname" in > + linux-gcc) > + sudo apt-get -q -y install gcc-8 > + ;; > + esac > + > mkdir --parents "$P4_PATH" > pushd "$P4_PATH" > wget --quiet "$P4WHENCE/bin.linux26x86_64/p4d" > @@ -32,11 +41,25 @@ osx-clang|osx-gcc) > brew link --force gettext > brew install caskroom/cask/perforce > ;; > +StaticAnalysis) > + sudo apt-get -q update > + sudo apt-get -q -y install coccinelle > + ;; > +Documentation) > + sudo apt-get -q update > + sudo apt-get -q -y install asciidoc xmlto > + ;; > esac > > -echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)" > -p4d -V | grep Rev. > -echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)" > -p4 -V | grep Rev. > -echo "$(tput setaf 6)Git-LFS Version$(tput sgr0)" > -git-lfs version > +if type p4d >/dev/null && type p4 >/dev/null > +then > + echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)" > + p4d -V | grep Rev. > + echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)" > + p4 -V | grep Rev. > +fi > +if type git-lfs >/dev/null > +then > + echo "$(tput setaf 6)Git-LFS Version$(tput sgr0)" > + git-lfs version > +fi ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' 2018-11-02 2:25 ` Junio C Hamano @ 2018-11-08 21:51 ` SZEDER Gábor 2018-11-09 2:59 ` Junio C Hamano 0 siblings, 1 reply; 9+ messages in thread From: SZEDER Gábor @ 2018-11-08 21:51 UTC (permalink / raw) To: Junio C Hamano; +Cc: Johannes Schindelin, Lars Schneider, Sebastian Staudt, git On Fri, Nov 02, 2018 at 11:25:17AM +0900, Junio C Hamano wrote: > SZEDER Gábor <szeder.dev@gmail.com> writes: > > > Ever since we started using Travis CI, we specified the list of > > packages to install in '.travis.yml' via the APT addon. While running > > our builds on Travis CI's container-based infrastructure we didn't > > have another choice, because that environment didn't support 'sudo', > > and thus we didn't have permission to install packages ourselves. With > > the switch to the VM-based infrastructure in the previous patch we do > > get a working 'sudo', so we can install packages by running 'sudo > > apt-get -y install ...' as well. > > OK, so far we learned that this is now _doable_; but not enough to > decide if this is a good thing to do or not. Let's read on to find > out. Yeah, this paragraph is just a bit of background about how the current situation came to be and what recent change made the switch possible. > > Let's make use of this and install necessary packages in > > 'ci/install-dependencies.sh', so all the dependencies (i.e. both > > packages and "non-packages" (P4 and Git-LFS)) are handled in the same > > file. > > So we used to have two waysto prepare the test environment; non > packaged software were done via install-dependencies.sh, but > packaged ones weren't. Unifying them so that the script installs > both would be a good change to simplify the procedure. > > Is that how this sentence argues for this change? Yes. > > Install gcc-8 only in the 'linux-gcc' build job; so far it has > > been unnecessarily installed in the 'linux-clang' build job as well. > > Is this "unneeded gcc-8 was installed" something we can fix only > because we now stopped doing the installation via apt addon? Now that you mention it: no. It would have been possible to install gcc-8 only in the 'linux-gcc' build job even via the apt addon, namely by removing the two Linux build jobs from the implicit build matrix and adding them as two independent build jobs in the 'matrix.include' section of '.travis.yml'. The drawback is that all the extra packages used in both build jobs would have to be duplicated. > Or we > could have fixed it while we were on apt addon but we didn't bother, > and this patch fixes it "while at it"---primarily because the shell > script is far more flexible to work with than travis.yml matrix and > this kind of customization is far easier to do? Basically yes (though I think it's not about not bothering; I don't know about others, but it just occured to me that it would have been doable, however, even if it occured to me earlier, because of the duplicated list of common packages I wouldn't have done it). Doing it in good old shell is indeed easier and the common packages are then only listed once. > > Print the versions of P4 and Git-LFS conditionally, i.e. only when > > they have been installed; with this change even the static analysis > > and documentation build jobs start using 'ci/install-dependencies.sh' > > to install packages, and neither of these two build jobs depend on and > > thus install those. > > > > This change will presumably be beneficial for the upcoming Azure > > Pipelines integration [1]: preliminary versions of that patch series > > run a couple of 'apt-get' commands to install the necessary packages > > before running 'ci/install-dependencies.sh', but with this patch it > > will be sufficient to run only 'ci/install-dependencies.sh'. > > So the main point of this change is to have less knowledge to > prepare the target configuration in the .travis.yml file and keep > them all in ci/install-dependencies.sh, which hopefully is more > reusable than .travis.yml in a non Travis environment? Oh, "more reusable" indeed, that's a more eloquent way to put it. > If that is the case, it makes sense to me. > > > This patch should go on top of 'ss/travis-ci-force-vm-mode'. > > > > I'm not sure about the last paragraph, because: > > > > - It talks about presumed benefits for a currently still > > work-in-progress patch series of an other contributor, and I'm not > > really sure that that's a good thing. Perhaps I should have > > rather put it below the '---'. > > > > - I'm confused about the name of this Azure thing. The cover letter > > mentions "Azure Pipelines", the file is called > > 'azure-pipelines.yml', but the relevant patch I link to talks > > about "Azure DevOps" in the commit message. > > > > Anyway, keep that last paragraph or drop it as you see fit. > > I hope we'll hear from Dscho in one or two revolutions of the Earth > ;-) ... revolutions around what? :) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' 2018-11-08 21:51 ` SZEDER Gábor @ 2018-11-09 2:59 ` Junio C Hamano 2018-11-09 12:08 ` Johannes Schindelin 0 siblings, 1 reply; 9+ messages in thread From: Junio C Hamano @ 2018-11-09 2:59 UTC (permalink / raw) To: SZEDER Gábor Cc: Johannes Schindelin, Lars Schneider, Sebastian Staudt, git SZEDER Gábor <szeder.dev@gmail.com> writes: >> > I'm not sure about the last paragraph, because: >> > >> > - It talks about presumed benefits for a currently still >> > work-in-progress patch series of an other contributor, and I'm not >> > really sure that that's a good thing. Perhaps I should have >> > rather put it below the '---'. >> > >> > - I'm confused about the name of this Azure thing. The cover letter >> > mentions "Azure Pipelines", the file is called >> > 'azure-pipelines.yml', but the relevant patch I link to talks >> > about "Azure DevOps" in the commit message. >> > >> > Anyway, keep that last paragraph or drop it as you see fit. >> >> I hope we'll hear from Dscho in one or two revolutions of the Earth >> ;-) > > ... revolutions around what? :) Originally I meant its own axis, but perhaps the moon. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' 2018-11-09 2:59 ` Junio C Hamano @ 2018-11-09 12:08 ` Johannes Schindelin 0 siblings, 0 replies; 9+ messages in thread From: Johannes Schindelin @ 2018-11-09 12:08 UTC (permalink / raw) To: Junio C Hamano; +Cc: SZEDER Gábor, Lars Schneider, Sebastian Staudt, git [-- Attachment #1: Type: text/plain, Size: 1453 bytes --] Hi, On Fri, 9 Nov 2018, Junio C Hamano wrote: > SZEDER Gábor <szeder.dev@gmail.com> writes: > > >> > I'm not sure about the last paragraph, because: > >> > > >> > - It talks about presumed benefits for a currently still > >> > work-in-progress patch series of an other contributor, and I'm not > >> > really sure that that's a good thing. Perhaps I should have > >> > rather put it below the '---'. > >> > > >> > - I'm confused about the name of this Azure thing. The cover letter > >> > mentions "Azure Pipelines", the file is called > >> > 'azure-pipelines.yml', but the relevant patch I link to talks > >> > about "Azure DevOps" in the commit message. > >> > > >> > Anyway, keep that last paragraph or drop it as you see fit. > >> > >> I hope we'll hear from Dscho in one or two revolutions of the Earth > >> ;-) > > > > ... revolutions around what? :) > > Originally I meant its own axis, but perhaps the moon. I see, you had fun talking about a revolution [*1*]... I am much in favor of this patch, as it indeed will simplify the integration into Azure Pipelines. As to the DevOps vs Pipelines thing: DevOps is the umbrella, it consists of much more than just the automated builds (Pipelines), it also has Boards, Packages, etc, but I don't think we will ever use that in the Git project, as our workflow is based out of a mailing list. Ciao, Dscho Footnote *1*: https://www.youtube.com/watch?v=Xv8FBjo1Y8I ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] travis-ci: no longer use containers 2018-10-26 0:09 ` Junio C Hamano 2018-10-26 1:39 ` SZEDER Gábor @ 2018-10-26 5:06 ` Sebastian Staudt 1 sibling, 0 replies; 9+ messages in thread From: Sebastian Staudt @ 2018-10-26 5:06 UTC (permalink / raw) To: gitster; +Cc: larsxschneider, szeder.dev, git Junio C Hamano <gitster@pobox.com> writes: > > Sebastian Staudt <koraktor@gmail.com> writes: > > > Travis CI will soon deprecate the container-based infrastructure > > enabled by `sudo: false` in ce59dffb34190e780be2fa9f449f842cadee9753. > > > > More info: > > https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures > > Thanks for posting a patch that would serve as a good discussion > starter. This is not a criticism on your patch, but more is a RFD > to those who helped our use of Travis by contributing to .travis.yml > and ci/. In fact this was the intention while creating this patch. Although I see I could have made this a bit clearer in the initial message. Having a patch that may cause a broken build or other CI problems seems more appropriate than waiting for Travis CI to flip the switch and searching for the problem afterwards. > Don't we need to do some other things so that we can run in vm > environment, rather than in container environment, before doing this > change? IOW, aren't we doing in .travis.yml something we can do > only in container but not in vm (if there is any), and if so, > shouldn't we be rewriting that something so that we can run in vm? > > I know ce59dffb ("travis-ci: explicity use container-based > infrastructure", 2016-01-26) only added "sudo: false" without doing > anything else (e.g. adding things that are only available to those > who run in container), but if we added stuff that are not usable in > vm environment after that commit since then, we need to adjust them > so that we can migrate to the container-based environment, no? > > To me, removing that "sudo: false" line seems like the least thing > we need to worry about. After all, they say that whether we have > "sudo: false" or not, the CI jobs will start running in vm > environment and not in container. So if the rest of .travis.yml is > ready to run in vm environment, we do not have to do anything ;-). > > In short, my question to Lars and SZEDER is, are we already prepared > to be thrown into a vm environment? > > If the answer is "yes", then I think removing "sudo: false" is > probably still a good thing to do for documentation purposes > (i.e. showing that we knew we are ready to go through their > migration). > > Thanks. > > > Signed-off-by: Sebastian Staudt <koraktor@gmail.com> > > --- > > .travis.yml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 4d4e26c9df..8d2499739e 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -1,7 +1,5 @@ > > language: c > > > > -sudo: false > > - > > cache: > > directories: > > - $HOME/travis-cache > > -- > > 2.19.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-09 12:08 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-25 17:41 [PATCH] travis-ci: no longer use containers Sebastian Staudt 2018-10-26 0:09 ` Junio C Hamano 2018-10-26 1:39 ` SZEDER Gábor 2018-11-01 11:47 ` [PATCH] travis-ci: install packages in 'ci/install-dependencies.sh' SZEDER Gábor 2018-11-02 2:25 ` Junio C Hamano 2018-11-08 21:51 ` SZEDER Gábor 2018-11-09 2:59 ` Junio C Hamano 2018-11-09 12:08 ` Johannes Schindelin 2018-10-26 5:06 ` [PATCH] travis-ci: no longer use containers Sebastian Staudt
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).