git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Git Test Coverage Report (Friday, Oct 12)
Date: Mon, 15 Oct 2018 10:09:13 +0200 (DST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1810151007430.561@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com>

Hi Stolee,

On Fri, 12 Oct 2018, Derrick Stolee wrote:

> 
> In an effort to ensure new code is reasonably covered by the test suite, we
> now have contrib/coverage-diff.sh to combine the gcov output from 'make
> coverage-test ; make coverage-report' with the output from 'git diff A B' to
> discover _new_ lines of code that are not covered.

Thanks for doing this. I do notice, though, that there are a few mentions
of BUG() lines, e.g.

> 0af129b2ed builtin/rebase--interactive2.c 267) BUG("invalid command '%d'",
> command);

I do not think that we will ever want to ensure that all of these lines
get code coverage ;-) Maybe it would be possible to exclude those lines
from the analysis?

Thank you,
Dscho

  reply	other threads:[~2018-10-15  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 12:59 Git Test Coverage Report (Friday, Oct 12) Derrick Stolee
2018-10-15  8:09 ` Johannes Schindelin [this message]
2018-10-15 13:23   ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1810151007430.561@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).