From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase
Date: Tue, 28 Aug 2018 14:53:13 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1808281451191.73@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqa7p7lmzp.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 27 Aug 2018, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> Please include this information in the commit message. It's super
> >> helpful to find this kind of information about why a patch does what
> >> it does when encountering a patch later "in the wild" (in git log -S
> >> output).
> >
> > I thought I did include the relevant part? As to the full back story: I
> > was repeatedly dressed down by Junio in recent attempts to include more
> > motivation in my commit messages. So I am reluctant to do as you say,
> > because Junio is the BDFL here.
>
> I do recall discouraging you from including irrelevant rant/whine in
> the log message a few times in the recent past, and also I do recall
> you never listening to me. Don't make me an excuse.
Junio, I would really appreciate less emotional, and more professional
conduct from you.
> I think what Jonathan finds helpful is the other half of the story
I will await Jonathan's clarification.
Ciao,
Dscho
> of what you did write in [1/1]. You wrote that it is no longer a
> shell script and needs to follow a separate calling convention.
> What was missing from that description that was given in [0/1] is
> why the original "rebase-in-c" series was done while pretending that
> the other effort "rebase-i-in-c" did not even exist, which made it
> necessary to do this change as a separate step.
>
> And I tend to agree that it _is_ a relevant story in this case.
>
>
next prev parent reply other threads:[~2018-08-28 12:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 21:35 [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase Johannes Schindelin via GitGitGadget
2018-08-22 21:35 ` [PATCH 1/1] builtin rebase: prepare for builtin rebase -i Johannes Schindelin via GitGitGadget
2018-08-22 21:50 ` [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase Junio C Hamano
2018-08-23 2:48 ` Jonathan Nieder
2018-08-25 23:46 ` Johannes Schindelin
2018-08-27 17:48 ` Junio C Hamano
2018-08-28 12:53 ` Johannes Schindelin [this message]
2018-08-28 15:34 ` Junio C Hamano
2018-08-29 13:24 ` Johannes Schindelin
2018-08-28 17:17 ` Jonathan Nieder
2018-08-29 14:29 ` Johannes Schindelin
2018-08-29 14:31 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2018-08-29 14:31 ` [PATCH v2 1/1] builtin rebase: prepare for builtin rebase -i Johannes Schindelin via GitGitGadget
2018-08-29 22:40 ` Junio C Hamano
2018-08-30 11:03 ` Johannes Schindelin
2018-08-30 20:09 ` Jeff King
2018-08-31 20:38 ` Johannes Schindelin
2018-08-31 20:48 ` Jeff King
2018-10-05 15:54 ` [PATCH v3 0/1] Teach the builtin rebase about the builtin interactive rebase Johannes Schindelin via GitGitGadget
2018-10-05 15:54 ` [PATCH v3 1/1] builtin rebase: prepare for builtin rebase -i Johannes Schindelin via GitGitGadget
2018-10-06 23:50 ` [PATCH v3 0/1] Teach the builtin rebase about the builtin interactive rebase Junio C Hamano
2018-10-12 7:59 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1808281451191.73@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).