From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Andrei Rybak <rybak.a.v@gmail.com>,
Git List <git@vger.kernel.org>, Thomas Rast <tr@thomasrast.ch>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC PATCH] line-log: clarify [a,b) notation for ranges
Date: Thu, 9 Aug 2018 14:50:18 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1808091448260.71@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <CAPig+cTVEq1AGvtxxonbU4PgqeG0fOy9CSDO7ThjVpfGoJaAJA@mail.gmail.com>
Hi Eric,
On Tue, 7 Aug 2018, Eric Sunshine wrote:
> On Tue, Aug 7, 2018 at 9:54 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> > line-log.[ch] use left-closed, right-open interval logic. Change comment
> > and debug output to square brackets+parentheses notation to help
> > developers avoid off-by-one errors.
> > ---
>
> This seems sensible. There might be some reviewers who suggest
> different notation since "[...)" is not universal (see [1]), but I
> think this is fine.
Indeed. When I started out studying mathematics, I learned the notation
[...[ (which makes a lot more sense, if you think about it).
Besides, it's not like we start from a fresh slate. Git is already over a
decade old. Our commit ranges are "half open", i.e. the exact thing that
is described here. There's gotta be some precedent in the documentation,
and introducing something willfully inconsistent is probably a pretty bad
idea.
Ciao,
Dscho
next prev parent reply other threads:[~2018-08-09 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 13:54 [RFC PATCH] line-log: clarify [a,b) notation for ranges Andrei Rybak
2018-08-07 21:47 ` Eric Sunshine
2018-08-09 12:50 ` Johannes Schindelin [this message]
2018-08-08 16:26 ` [PATCH v2] " Andrei Rybak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1808091448260.71@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rybak.a.v@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).