From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 767A71F597 for ; Mon, 30 Jul 2018 16:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731355AbeG3SGr (ORCPT ); Mon, 30 Jul 2018 14:06:47 -0400 Received: from mout.gmx.net ([212.227.15.18]:44443 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbeG3SGr (ORCPT ); Mon, 30 Jul 2018 14:06:47 -0400 Received: from [192.168.0.129] ([37.201.193.26]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mb8MV-1fPcBX2Wip-00KeoO; Mon, 30 Jul 2018 18:30:56 +0200 Date: Mon, 30 Jul 2018 18:30:55 +0200 (DST) From: Johannes Schindelin X-X-Sender: virtualbox@gitforwindows.org To: Eric Sunshine cc: gitgitgadget@gmail.com, Git List , Junio C Hamano , Thomas Rast Subject: Re: [PATCH v4 11/21] range-diff: add tests In-Reply-To: Message-ID: References: <2b8d09020fff0ac220c1878c65b47290c5245cb9.1532210683.git.gitgitgadget@gmail.com> User-Agent: Alpine 2.21.1 (DEB 209 2017-03-23) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Provags-ID: V03:K1:l0xgfUWBDyhdsKOM4DJsQBKKnjCMlUpe4i0URjYrfSAAAnQnp6P Gyg5JzQOjmfY769en41e8wBYWNnKm3EiKAmPBWEwHfIT0Z2PWHDHelHfM0+mX8HcbPgbEvT 5iQg9gND+s+vX7vL6S2h6mugeM8/k4jn0n+gAB3DnM+p74cXoFmXcZ4kwGVgjVSVo7a1hGg 1s3qezq1pNg+bKw6jQNrQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:v2JFsxtuHxg=:ak9w/ObO0y90bCW8UrZ6G8 rR87fV/8L9+7cYEs6i2d3ywZ2NgUbGTMz5PE3h6qC1kw17uqRw80Xueq/z3A1OYtqI4UXlegD 9Yli0mQGIGrbHCE28TbW+9+2jb1liCRSOiZjb0uze5QdQYz7F3Gb7AW3+OZf2V31p9X8KoVc7 HjuauWl7c6HoWK+du1kjabP7QuA89LIkYvmjeTnOKSK1Fw8pchj1HGvRz4pGy9YZBpZWmbxSQ mixhWwZLEYLQ9EQEooYbkKGAYM6hGfm1qX+zKI8zFW/dvNZLOQMK9Fj7gzWllvf03sa7G04hp 4J8dMPmqlms1usfKurdkgkuOfl+kOGAQd3RnmsZfk0urt37nSum/9U7lAWFvapTYnoZeZ+53W m+I3ldTZziUKTSpJWJbdsbmvc/ULUId0x91hCfhe9FN3eEn/ClJP2uYB5AzFlv3KR0r6s+6gq BM2FQ7mtLy26uhNoMMmoLMe36m3LP++nxkE+rv4U57z6Qwn70W05vc1sr2pOpmf2b5jID8CS5 4h0NXAcw62EHCkcNWMyDjF8PZDXbEy1uWApRFCBSPMZbHtdmXfwq/nA7bE6M8BKdOKeOuYf4F EnwFuZ1sufJnTSacRQAUAIOhFgBZ2JbTgyiYX+BCeXOhn8pImz0rYasiph2EdyUnx/D2tYiog geK/nEWE7xNVeWbALo9nuwjsWK9dYwBtA+S9WCWJJ92g8J67R/+thrwFza4ayq6yFmQ1NBe9C BKF18oUUk3nkSrprxWky5qzADweTPFggEJpVg/y4tYL1WiiSMtizYD9n9LGP/J1KugpT3B0+J 2Sx1dM5 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Eric, On Sun, 22 Jul 2018, Eric Sunshine wrote: > On Sat, Jul 21, 2018 at 6:05 PM Thomas Rast via GitGitGadget > wrote: > > These are essentially lifted from https://github.com/trast/tbdiff, with > > light touch-ups to account for the command now being names `git > > s/names/named/ Thanks. I already pushed an update to https://github.com/gitgitgadget/git/pull/1. Ciao, Dscho > > > range-diff`. > > > > Apart from renaming `tbdiff` to `range-diff`, only one test case needed > > to be adjusted: 11 - 'changed message'. > > > > The underlying reason it had to be adjusted is that diff generation is > > sometimes ambiguous. In this case, a comment line and an empty line are > > added, but it is ambiguous whether they were added after the existing > > empty line, or whether an empty line and the comment line are added > > *before* the existing empty line. And apparently xdiff picks a different > > option here than Python's difflib. > > > > Signed-off-by: Johannes Schindelin >