From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ben Peart <Ben.Peart@microsoft.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"sbeller@google.com" <sbeller@google.com>
Subject: Re: [PATCH v3] handle lower case drive letters on Windows
Date: Sun, 15 Jul 2018 00:15:59 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1807150015350.75@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqva9kurba.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Thu, 12 Jul 2018, Junio C Hamano wrote:
> Ben Peart <Ben.Peart@microsoft.com> writes:
>
> >> > Thanks. I thought it was strange as well until I realized you only
> >> > see the error message if there _isn't_ a valid drive letter so seeing
> >> > the entire path makes sense as it will likely be something like
> >> "\\server\volume\directory"
> >>
> >> Yup, that is why I thought Dscho meant to say something like
> >>
> >> "'%s': path without valid drive prefix"
> >>
> >> in my response ;-)
> >
> > I'm fine with that - want me to leave it alone, spin a V4 or have you tweak it?
>
> That's "helped-by Dscho" patch, so I'd leave it to him by queuing v3
> overnight and wait to deal with the final decision by the weekend
> ;-) That way, I do not have to make a decision on anything Windows
> related.
The tweaked error message is fine by me.
Ciao,
Dscho
prev parent reply other threads:[~2018-07-14 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 17:54 [PATCH v1] handle lower case drive letters on Windows Ben Peart
2018-07-11 17:59 ` Stefan Beller
2018-07-11 19:07 ` Ben Peart
2018-07-11 20:11 ` Junio C Hamano
2018-07-11 21:30 ` Ben Peart
2018-07-11 21:41 ` [PATCH v2] " Ben Peart
2018-07-12 13:59 ` [PATCH v1] " Johannes Schindelin
2018-07-12 16:33 ` Junio C Hamano
2018-07-12 15:44 ` [PATCH v3] " Ben Peart
2018-07-12 19:12 ` Junio C Hamano
2018-07-12 19:23 ` Ben Peart
2018-07-12 19:53 ` Junio C Hamano
2018-07-12 20:09 ` Ben Peart
2018-07-12 20:34 ` Junio C Hamano
2018-07-14 22:15 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1807150015350.75@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=Ben.Peart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).