From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Paul Smith <paul@mad-scientist.net>
Cc: Git mailing list <git@vger.kernel.org>, Dan Jacques <dnj@google.com>
Subject: Re: Git 2.18: RUNTIME_PREFIX... is it working?
Date: Wed, 4 Jul 2018 13:22:02 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1807041312150.75@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <97803ec8dae0a73bae301a37377b7b4a78f77e99.camel@mad-scientist.net>
Hi Paul,
On Wed, 4 Jul 2018, Paul Smith wrote:
> I was excited to see the RUNTIME_PREFIX for POSIX systems patchset go
> by earlier this year. Although I didn't see any mention of it being
> included in the 2.18.0 release notes, it does appear that it was merged
> in for this release.
>
> Has anyone else tried to get it working? It doesn't appear to be
> working properly for me so I'm not sure if I'm supposed to be doing
> something different... I didn't see any documentation on it.
It is working (for ages) in the Git for Windows build.
> Basically what happens is that I run configure with
> --prefix=/my/install/path --with-gitconfig=etc/gitconfig
> --with-gitattributes=etc/gitattributes.
>
> Then I run make with RUNTIME_PREFIX=YesPlease.
Ah. In Git for Windows, we do not use configure. I *think* this points to
an incompatibility of the RUNTIME_PREFIX feature with our autoconf
support, and this is a grand opportunity for you to step in and help.
Essentially, what you will want to do is to implement a new configure
option --with-runtime-prefix that then prevents the autoconf script from
munging the relative paths in the way it does.
> When I look in the makefile, I see that the make variable gitexecdir is
> initially properly set to libexec/git-core which is what I expect.
>
> However, later in the makefile we include the config.mak.autogen file,
> which was generated from config.mk.in by configure. In the .in file we
> have this:
>
> gitexecdir = @libexecdir@/git-core
>
> After configure gets done with it, this becomes:
>
> gitexecdir = ${prefix}/libexec/git-core
>
> which is a fully-qualified path. This means that exec-cmd.c is
> compiled with -DGIT_EXEC_PATH="/my/install/path/libexec/git-core" which
> effectively disables RUNTIME_PREFIX, as the exec-cmd.c:system_prefix()
> function always returns FALLBACK_RUNTIME_PREFIX since GIT_EXEC_PATH is
> not a suffix of executable_dirname (once the install location has been
> moved).
Right.
I am actually quite surprised that it builds for you, given this part of
the Makefile:
-- snip --
ifdef RUNTIME_PREFIX
ifneq ($(filter /%,$(firstword $(gitexecdir_relative))),)
$(error RUNTIME_PREFIX requires a relative gitexecdir, not: $(gitexecdir))
endif
[...]
-- snap --
I am also quite surprised that config.mk.in tries to set gitexecdir. But I
guess that is for cases where you want to override it via --libexecdir?
> I suppose we need to pass more configure options to reset paths; is
> there information somewhere on exactly which ones should be overridden?
> For example if I try to pass configure --libexecdir=libexec to solve
> the above issue, I get an error from configure:
>
> configure: error: expected an absolute directory name for --libexecdir: libexec
>
> Any info on how this is supposed to work, is welcome!
I just saw another thing:
-- snip --
exec-cmd.sp exec-cmd.s exec-cmd.o: GIT-PREFIX
exec-cmd.sp exec-cmd.s exec-cmd.o: EXTRA_CPPFLAGS = \
'-DGIT_EXEC_PATH="$(gitexecdir_SQ)"' \
'-DGIT_LOCALE_PATH="$(localedir_relative_SQ)"' \
'-DBINDIR="$(bindir_relative_SQ)"' \
'-DFALLBACK_RUNTIME_PREFIX="$(prefix_SQ)"'
-- snap --
Is it possible that we should use `gitexecdir_relative_SQ` here instead?
Does that fix things for you?
I Cc:ed Dan so he could correct my hunch that this GIT_EXEC_PATH
definition needs to be fixed.
Ciao,
Johannes
next prev parent reply other threads:[~2018-07-04 11:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 5:12 Git 2.18: RUNTIME_PREFIX... is it working? Paul Smith
2018-07-04 11:22 ` Johannes Schindelin [this message]
2018-07-05 15:36 ` Paul Smith
2018-07-06 9:00 ` Johannes Schindelin
2018-07-06 13:18 ` Daniel Jacques
2018-07-08 18:52 ` Paul Smith
2018-07-08 21:52 ` Johannes Schindelin
2018-07-09 19:58 ` Jeff King
2018-07-09 20:26 ` Johannes Schindelin
2018-07-10 2:21 ` Jeff King
2018-07-10 11:40 ` Johannes Schindelin
2018-07-10 14:03 ` Daniel Jacques
2018-07-10 16:09 ` Junio C Hamano
2018-07-09 21:05 ` Junio C Hamano
2018-07-10 3:56 ` Jeff King
2018-07-10 7:13 ` Perry Hutchison
2018-07-10 14:03 ` Jeff King
2018-07-10 22:20 ` Jonathan Nieder
2018-07-10 22:21 ` Jonathan Nieder
2018-07-17 9:45 ` Johannes Schindelin
2018-07-14 20:51 ` brian m. carlson
2018-07-18 12:18 ` Johannes Schindelin
2018-07-19 22:26 ` brian m. carlson
2018-07-20 14:29 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1807041312150.75@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=dnj@google.com \
--cc=git@vger.kernel.org \
--cc=paul@mad-scientist.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).