From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
Tiago Botelho <tiagonbotelho@gmail.com>,
git <git@vger.kernel.org>,
Harald Nordgren <haraldnordgren@gmail.com>,
Tiago Botelho <tiagonbotelho@hotmail.com>
Subject: Re: [RFC PATCH v5] Implement --first-parent for git rev-list --bisect
Date: Thu, 28 Jun 2018 15:08:22 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1806281505160.73@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqwoukgpr9.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, 27 Jun 2018, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > git rev-list --bisect-all --first-parent F..E >revs &&
> > # only E, e1..e8 should be listed, nothing else
> > test_line_count = 9 revs &&
> > for rev in E e1 e2 e3 e4 e5 e6 e7 e8
> > do
> > grep "^$(git rev-parse $rev) " revs || return
> > done
> >
> > I am faster by... a lot. Like, seconds instead of minutes.
>
> I'm fine either way. I just thought you would not want 9 separate
> invocations of grep ;-)
I don't.
I like the unnecessary test_commit calls even less ;-)
And yes, we could avoid those `grep` calls, I know. By something as
convoluted as
revs="$(cat revs)" &&
for rev in $(git rev-parse E e1 e2 e3 e4 e5 e6 e7 e8)
do
case "$LF$revs" in
*"$LF$rev "*) ;; # okay
*) echo "Missing: $rev">&2; return 1;;
esac
done
Is this really what you would call an easy-to-understand test? Maybe for
you, a Unix oldtimer and shell scripting king.
Ciao,
Dscho
next prev parent reply other threads:[~2018-06-28 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 12:39 [RFC PATCH v5] Implement --first-parent for git rev-list --bisect Tiago Botelho
2018-06-25 17:33 ` Junio C Hamano
2018-06-26 11:59 ` Christian Couder
2018-06-26 14:10 ` Johannes Schindelin
2018-06-26 15:41 ` Christian Couder
2018-06-26 21:16 ` Johannes Schindelin
2018-06-26 22:20 ` Junio C Hamano
2018-06-27 11:48 ` Johannes Schindelin
2018-06-27 16:26 ` Junio C Hamano
2018-06-28 13:08 ` Johannes Schindelin [this message]
2018-06-28 16:12 ` Junio C Hamano
2018-06-29 11:20 ` Johannes Schindelin
2018-07-03 21:33 ` Tiago Botelho
2018-07-03 22:36 ` Junio C Hamano
2018-07-04 10:26 ` Johannes Schindelin
2018-07-06 18:14 ` Junio C Hamano
2018-07-06 20:33 ` Johannes Schindelin
2018-07-06 21:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1806281505160.73@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=haraldnordgren@gmail.com \
--cc=tiagonbotelho@gmail.com \
--cc=tiagonbotelho@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).