git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>, Alban Gruin <alban.gruin@gmail.com>
Cc: git@vger.kernel.org
Subject: ag/rebase-i-append-todo-help, was Re: What's cooking in git.git (Jun 2018, #06; Mon, 25)
Date: Tue, 26 Jun 2018 11:28:11 +0200 (DST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1806261125330.21419@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqin66mql6.fsf@gitster-ct.c.googlers.com>

Hi Junio & Alban,

On Mon, 25 Jun 2018, Junio C Hamano wrote:

> * ag/rebase-i-append-todo-help (2018-06-14) 2 commits
>  - rebase--interactive: rewrite append_todo_help() in C
>  - Merge branch 'ag/rebase-p' into ag/rebase-i-append-todo-help
>  (this branch is used by ag/rebase-i-rewrite-todo.)
> 
>  Stepwise rewriting of the machinery of "rebase -i" into C continues.

I just reviewed this on GitHub (which gives me an interactive way to look
around outside of the diff context) and I think there are two things left
to do (which I mentioned to Alban on IRC):

- `msg = _(...)` should be `msg = N_(...)` instead, with the corresponding
  `_(msg)` later on, and

- to avoid cluttering sequencer.c, and to pave the way for future `rebase
  -i`-specific code, the `append_todo_help()` function should go into a
  new file called `interactive-rebase.c`.

Ciao,
Dscho

  reply	other threads:[~2018-06-26  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 22:47 What's cooking in git.git (Jun 2018, #06; Mon, 25) Junio C Hamano
2018-06-26  9:28 ` Johannes Schindelin [this message]
2018-06-26 11:07 ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1806261125330.21419@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=alban.gruin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).