From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Wink Saville <wink@saville.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [RFC PATCH 0/1] bdl-lib.sh: add bash debug logger
Date: Thu, 5 Apr 2018 15:37:58 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1804051536080.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz> (raw)
In-Reply-To: <CAKk8isqA6Ru05kRJ+xiVHEkzPgH24cKUZbbgw2tEnw4rhafDQw@mail.gmail.com>
Hi Wink,
On Fri, 30 Mar 2018, Wink Saville wrote:
> On Fri, Mar 30, 2018 at 3:34 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >
> > On Tue, 27 Mar 2018, Wink Saville wrote:
> >
> >> Add bdl-lib.sh which provides functions to assit in debugging git
> >> shell scripts and tests.
> >
> > Interesting idea. It is Bash-only, though... (and it is not a secret
> > that I want to discourage using Unix shell scripts in Git's production
> > code, they are a decent way to prototype things, but they fall short
> > of being robust and portable in practice, and don't get me started on
> > speed issues).
> >
> > So rather than spending time on making it easier to debug shell
> > scripts, I would love to see us going into the direction of a
> > consistent C source code. I still believe that we can get there, and
> > that the benefits are worth the (huge) effort.
>
> I totally agree the code base should use primarily one language!
Great!
> But that's not the case now and "bdl" gave me insight into the workings
> of rebase--interactive and I found little guidance on how to debug
> or learn the code base. So I thought I'd see if there was interest
> in what I'd done.
And realistically, requiring Bash is not all that much of a problem when
targeting developers.
> If I were to make it non-bash specific would there be any interest?
After thinking about this more, I am a lot less opposed to including this
in Git's source code. However, as it is not necessary for Git's
functionality, it should probably go into contrib/, and I would much
rather have a more descriptive name such as
contrib/bash-debugging-library/...
Ciao,
Johannes
next prev parent reply other threads:[~2018-04-05 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 0:15 [RFC PATCH 0/1] bdl-lib.sh: add bash debug logger Wink Saville
2018-03-28 0:15 ` [RFC PATCH 1/1] " Wink Saville
2018-03-30 10:34 ` [RFC PATCH 0/1] " Johannes Schindelin
2018-03-30 22:30 ` Wink Saville
2018-04-05 13:37 ` Johannes Schindelin [this message]
2018-04-05 14:26 ` Wink Saville
2018-04-05 19:32 ` Johannes Schindelin
2018-04-05 23:32 ` Wink Saville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1804051536080.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=wink@saville.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).