From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id E05331F404 for ; Wed, 10 Jan 2018 23:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbeAJXJc (ORCPT ); Wed, 10 Jan 2018 18:09:32 -0500 Received: from mout.gmx.net ([212.227.17.21]:60664 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752567AbeAJXJb (ORCPT ); Wed, 10 Jan 2018 18:09:31 -0500 Received: from [192.168.0.129] ([37.201.193.20]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mg3h3-1eCdK04A1F-00NPrf; Thu, 11 Jan 2018 00:09:22 +0100 Date: Thu, 11 Jan 2018 00:09:19 +0100 (STD) From: Johannes Schindelin X-X-Sender: virtualbox@MININT-6BKU6QN.europe.corp.microsoft.com To: Beat Bolli cc: sunshine@sunshineco.com, git@vger.kernel.org, peff@peff.net Subject: Re: [PATCH v2] t3900: add some more quotes In-Reply-To: <20180110223840.1481-1-dev+git@drbeat.li> Message-ID: References: <20180110223840.1481-1-dev+git@drbeat.li> User-Agent: Alpine 2.21.1 (DEB 209 2017-03-23) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Provags-ID: V03:K0:Op7TAxFLu67UE7Vxwx+PVC5+vzv847ycRCDmWTMnZfM+zYFho6L VUeHOLyGs4ZQuVEH+AMYq71ldvPTCDJj2q4M1vBeNGVXsRdy40akYEJrXNEfWDML8YY9cf8 epkJ2koCTfwNzcvyzji+mNPDbQBtNjwKDHQBb49HH8CizOEC5MA/iaqrrmC20e5or+7KdaC QVBNnBYEwAliF22RpkNkA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ckqr6uDtfG8=:3tUnAOgJXsSvaYfzrWM8oB AgyBQSzeDz3aHrxk0nMwunyfS+KmdRge9itGOo+Ho+S9Qqw8acuYykYcCtmaYDaOF8CdJYTP1 1i/1BsQu7xyyP98WAGhNQAeQsG/DKwfakbKP5QKytCvLUOe8kkCGsT51GjbQbdS634jFJzzJz cfgdruYrF8iEf90vOszS/yhDwDax/5Tv8+MlrVVCcFzKcm2RpLGoL3gV+25zgQ9Y0McOoP2DM bAtQ7Gxk1jlDTLeByZ7Ar3HssyKT0psPbgJ08Sj5eKW12crHzmNpqnXQfeUvJPxOsVk8C7ONW QywrFwlQunGPSUREL1CfvQzwWti4pyQQVwzdPaPQv1m0dWESAiZ7IiS3b69DNrOWP1iaRl5BA Vkrs7lcDIvwvfBX2RmODwPW5dFLDipHcqUlw1akkyAnsGJsPh3j8Suu5HcUdcTZaxc1oksey1 6dctrIfDiQ6Y7GNLs31GSk5mVkNttSPNQ9fEanc7j4qouJcV+e30pUVoyUAoJOn5vKwWXlZ5R IyGPp0GAeYgK2hZbCR5S3v3Yrv8kH3vsWIJE1ioP0qOX+KtpB4ejzW/PcBWwDxUMC6v8Yx0zu xvcIo8n6zcnA8vUDXkJAuNol1Eqc0c42trANVBI1N+w5Vc9HRBqgM52mSjgyI/dWageTtpvLG kIclKaci8WxeeJErQfMqlg6hKvBtUlQR2afAPhmSELKSx0BhMqfh1Be8ZVpboV8XbrT6CDuOQ nm1xdXfSB0VP3ReOvO7yZoLRkAOX4JYRr/Sr+zS5/ggYGYTV5qgGVSzEstlp4vjjfvEK3Fs7L 0ZNsjbTqR2ZktN3MWyQbEgesAYJIq4hhkC6C0i7Lcoep/Uocb0= Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Beat, On Wed, 10 Jan 2018, Beat Bolli wrote: > diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh > index 9e4e694d9..dc00db87b 100755 > --- a/t/t3900-i18n-commit.sh > +++ b/t/t3900-i18n-commit.sh > @@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' ' > ' > > test_expect_success 'UTF-8 invalid characters refused' ' > - test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" && > + test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" && It is probably worth quoting the dollar characters, too, as pointed out by Hannes Sixt: we want to interpolate the value only when needed, just in case that the HOME variable contains double quotes. Ciao, Dscho