From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Beat Bolli <dev+git@drbeat.li>
Cc: sunshine@sunshineco.com, git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH v2] t3900: add some more quotes
Date: Thu, 11 Jan 2018 00:09:19 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1801110008030.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz> (raw)
In-Reply-To: <20180110223840.1481-1-dev+git@drbeat.li>
Hi Beat,
On Wed, 10 Jan 2018, Beat Bolli wrote:
> diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh
> index 9e4e694d9..dc00db87b 100755
> --- a/t/t3900-i18n-commit.sh
> +++ b/t/t3900-i18n-commit.sh
> @@ -40,7 +40,7 @@ test_expect_success 'UTF-16 refused because of NULs' '
> '
>
> test_expect_success 'UTF-8 invalid characters refused' '
> - test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
> + test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&
It is probably worth quoting the dollar characters, too, as pointed out by
Hannes Sixt: we want to interpolate the value only when needed, just in
case that the HOME variable contains double quotes.
Ciao,
Dscho
next prev parent reply other threads:[~2018-01-10 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:58 [PATCH] t3900: add some more quotes Beat Bolli
2018-01-10 10:33 ` Jeff King
2018-01-10 17:21 ` Johannes Schindelin
2018-01-10 17:44 ` Eric Sunshine
2018-01-10 22:38 ` [PATCH v2] " Beat Bolli
2018-01-10 23:09 ` Johannes Schindelin [this message]
2018-01-10 23:09 ` Junio C Hamano
2018-01-10 19:02 ` [PATCH] " Johannes Sixt
2018-01-10 19:43 ` Junio C Hamano
2018-01-10 19:53 ` Jeff King
2018-01-10 21:31 ` Junio C Hamano
2018-01-11 9:38 ` Jeff King
2018-01-11 11:39 ` read test snippet from stdin [was: [PATCH] t3900: add some more quotes] SZEDER Gábor
2018-01-11 12:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1801110008030.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz \
--to=johannes.schindelin@gmx.de \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).