git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Daniel Stenberg <daniel@haxx.se>
To: Jeff King <peff@peff.net>
Cc: "Daniel Carpenter" <dc@ammonit.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: http.sslVersion only specifies minimum TLS version, later versions are allowed
Date: Mon, 3 May 2021 22:56:54 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.2105032250540.30150@fvyyl> (raw)
In-Reply-To: <YJBhH0eLKRSpPFy3@coredump.intra.peff.net>

On Mon, 3 May 2021, Jeff King wrote:

> I think it would also make sense to improve the documentation for 
> http.sslVersion to make it clear that this is a minimum (the current wording 
> is quite misleading).

While improving the http.sslVersion, maybe also consider dropping the special 
mention of NSS and OpenSSL in there? Maybe just like this:

         The SSL version to use when negotiating an SSL connection, if you
         want to force the default.  The available and default version
-       depend on whether libcurl was built against NSS or OpenSSL and the
-       particular configuration of the crypto library in use. Internally
+       depend on which TLS library libcurl was built to use. Internally
         this sets the 'CURLOPT_SSL_VERSION' option; see the libcurl
         documentation for more details on the format of this option and
         for the ssl version supported. Currently the possible values of

Maybe also consider dropping 'sslv2' and 'sslv3' from the docs now since 
virtually no TLS library supports them since several years now (as they're 
considered insecure and bad) and therefor asking curl to use those will more 
often than not rather cause an error.

-- 

  / daniel.haxx.se

  reply	other threads:[~2021-05-03 21:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 11:56 Daniel Carpenter
2021-05-03 13:55 ` Ævar Arnfjörð Bjarmason
2021-05-03 14:10   ` Jeff King
2021-05-03 15:02     ` Daniel Carpenter
2021-05-03 20:46       ` Jeff King
2021-05-03 20:56         ` Daniel Stenberg [this message]
2021-05-03 21:01         ` Randall S. Becker
2021-05-03 21:09           ` Daniel Stenberg
2021-05-03 21:23             ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.2105032250540.30150@fvyyl \
    --to=daniel@haxx.se \
    --cc=avarab@gmail.com \
    --cc=dc@ammonit.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).