git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: gitster@pobox.com
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: pd/fetch-jobs, was Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)
Date: Sat, 14 Sep 2019 06:58:37 -0700 (PDT)	[thread overview]
Message-ID: <mhng-2c9b8fd0-22e7-4679-9d9b-f8128881fada@palmer-si-x1e> (raw)
In-Reply-To: <xmqq8sqtgzp9.fsf@gitster-ct.c.googlers.com>

On Thu, 12 Sep 2019 11:02:42 PDT (-0700), gitster@pobox.com wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>>> * pd/fetch-jobs (2019-08-13) 5 commits
>>>  . fetch: make --jobs control submodules and remotes
>>>  . fetch: add the --submodule-fetch-jobs option
>>>  . fetch: add the fetch.jobs config key
>>>  . fetch: add the "--fetch-jobs" option
>>>  . fetch: rename max_children to max_children_for_submodules
>>>
>>>  "git fetch --jobs" is getting taught to also run fetch jobs in
>>>  parallel when fetching from multiple remote repositories.
>>>
>>>  Comments?
>>
>> I still stand by my suggestion that it is undesirable (and makes the
>> code much more complicated than necessary) to end up with three options.
>> Having only `--jobs=<n>` would be the ideal solution.
>
> I think exposing "--jobs" as the primary UI element is a good longer
> term goal; the approach taken in the intermediate step would be a
> necessary one for backward compatibility.
>
> I stopped carrying it in 'pu' some weeks ago (I suspect it had some
> interactions with other topics in flight, by causing either test
> failures or textual conflicts).  Perhaps somebody interested enough
> in the topic can resurrect it.

Sorry, I'm somewhat new to the git development process.  I'm happy to re-spin 
the patch set, I'm just not sure what do to here.  It looks like there are some 
test failures when I rebase to the latest master, which I'm happy to fix.  Just 
let me know if I should:

* Send all 5 patches, under the assumption that the last one will not get 
  merged until some time later.
* Send just the first 4 patches, holding onto the last one for later.
* Send just a single patch, which wouldn't add the --fetch-jobs and 
  --submodule-fetch-jobs arguments.

  reply	other threads:[~2019-09-14 13:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07 17:26 What's cooking in git.git (Sep 2019, #01; Sat, 7) Junio C Hamano
2019-09-09 18:58 ` Denton Liu
2019-09-09 19:57   ` Junio C Hamano
2019-09-10  0:18     ` Denton Liu
2019-09-09 23:47 ` brian m. carlson
2019-09-10  0:19   ` Junio C Hamano
2019-09-28 23:31   ` Junio C Hamano
2019-09-28 23:35     ` brian m. carlson
2019-09-10  5:04 ` Martin Ågren
2019-09-10 18:23 ` Josh Steadmon
2019-09-11  1:03 ` Matheus Tavares Bernardino
2019-09-11 12:01 ` pd/fetch-jobs, was " Johannes Schindelin
2019-09-12 18:02   ` Junio C Hamano
2019-09-14 13:58     ` Palmer Dabbelt [this message]
2019-09-16 17:43       ` Junio C Hamano
2019-09-16 20:40         ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-2c9b8fd0-22e7-4679-9d9b-f8128881fada@palmer-si-x1e \
    --to=palmer@sifive.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).