From: Jakub Narebski <jnareb@gmail.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Cc: gitster@pobox.com, joe@perches.com, git@vger.kernel.org
Subject: Re: [PATCH] send-email: auth plain/login fix
Date: Mon, 26 Sep 2011 10:24:21 -0700 (PDT) [thread overview]
Message-ID: <m3fwjjp69m.fsf@localhost.localdomain> (raw)
In-Reply-To: <1316879367-1182-1-git-send-email-zbyszek@in.waw.pl>
Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> git send-email was not authenticating properly when communicating over
> TLS with a server supporting only AUTH PLAIN and AUTH LOGIN. This is
> e.g. the standard server setup under debian with exim4 and probably
> everywhere where system accounts are used.
>
> The solution comes from this forum thread:
> http://www.perlmonks.org/?node_id=904354
Signoff?
> ---
> git-send-email.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git git-send-email.perl git-send-email.perl
> index 37dfbe7..100fbd9 100755
> --- git-send-email.perl
> +++ git-send-email.perl
> @@ -27,6 +27,7 @@ use Term::ANSIColor;
> use File::Temp qw/ tempdir tempfile /;
> use File::Spec::Functions qw(catfile);
> use Error qw(:try);
> +use Authen::SASL qw(Perl);
> use Git;
> use MIME::Base64;
Shouldn't we load Authen::SASL only when it is necessary (on demand),
rather than forcing everybody who use send-email (even if via
sendmail, or with other authentication support)?
We load Net::SMTP::SSL only on demand.
It would be:
require Authen::SASL;
Authen::SASL->import(qw(Perl));
--
Jakub Narębski
next prev parent reply other threads:[~2011-09-26 17:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 0:40 [PATCH] git-send-email: Add AUTH LOGIN support Joe Perches
2011-08-06 4:54 ` Junio C Hamano
2011-08-06 5:21 ` Joe Perches
2011-08-19 1:16 ` Joe Perches
2011-08-19 23:09 ` Junio C Hamano
2011-08-19 23:24 ` Joe Perches
2011-08-20 1:01 ` Junio C Hamano
2011-09-24 15:49 ` [PATCH] send-email: auth plain/login fix Zbigniew Jędrzejewski-Szmek
2011-09-26 16:38 ` Junio C Hamano
2011-09-26 16:59 ` Joe Perches
2011-09-26 17:24 ` Jakub Narebski [this message]
2011-09-27 21:36 ` [PATCH v2] " Zbigniew Jędrzejewski-Szmek
2011-09-27 21:48 ` Jeff King
2011-09-28 10:26 ` [PATCH v3] " Zbigniew Jędrzejewski-Szmek
2011-09-28 22:00 ` Junio C Hamano
2011-09-29 14:16 ` [PATCH v4] " Zbigniew Jędrzejewski-Szmek
2011-09-29 15:01 ` Joe Perches
2011-09-29 17:02 ` [PATCH] " Zbigniew Jędrzejewski-Szmek
2011-09-29 18:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwjjp69m.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joe@perches.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).