git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH RFC] gettext: Support building on non-GNU with -lintl
Date: Sat, 05 Jun 2010 04:42:50 -0700 (PDT)	[thread overview]
Message-ID: <m3aar9r9ek.fsf@localhost.localdomain> (raw)
In-Reply-To: <1275669370-6004-1-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change the build process on non-GNU systems to use -lintl if
> NO_GETTEXT hasn't been set.
> 
> Systems that use the GNU C Library don't need this, but on others the
> GNU libintl library is an externally install package, so we need to
> explicitly link to it.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

[...]
> diff --git a/Makefile b/Makefile
> index 5169aec..1dfcd65 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -28,6 +28,15 @@ all::
>  # Define NO_EXPAT if you do not have expat installed.  git-http-push is
>  # not built, and you cannot push using http:// and https:// transports.
>  #
> +# Define NO_GETTEXT if you don't have libintl installed, or don't want
> +# to build Git with localization support.
> +#
> +# Define NEEDS_LIBINTL if you haven't defined NO_GETTEXT=YesPlease,
> +# but your system needs to be explicitly linked to -lintl. This is
> +# defined automatically if we're building gettext support on systems
> +# where we expect not to use glibc (which has libintl included in
> +# libc).

Could you add test for NEEDS_LIBINTL to configure.ac?  Thanks in
advance.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2010-06-05 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 16:36 [PATCH RFC] gettext: Support building on non-GNU with -lintl Ævar Arnfjörð Bjarmason
2010-06-05 11:42 ` Jakub Narebski [this message]
2010-06-05 14:57   ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3aar9r9ek.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).