From: Jakub Narebski <jnareb@gmail.com>
To: Jeff Epler <unpythonic.net@unpythonic.net>
Cc: git@vger.kernel.org, Jeff Epler <jepler@unpythonic.net>
Subject: Re: [PATCH 2/2] document new flags
Date: Sat, 30 May 2009 01:19:53 -0700 (PDT) [thread overview]
Message-ID: <m38wkfatqc.fsf@localhost.localdomain> (raw)
In-Reply-To: <1243647555-25098-2-git-send-email-user@lamp>
Jeff Epler <unpythonic.net@unpythonic.net> writes:
> From: Jeff Epler <jepler@unpythonic.net>
>
> Signed-off-by: Jeff Epler <jepler@unpythonic.net>
> ---
> Documentation/git-cherry.txt | 14 +++++++++++++-
> 1 files changed, 13 insertions(+), 1 deletions(-)
Why split this patch in two? It is better to have new feature and
documentation together, I think.
> diff --git a/Documentation/git-cherry.txt b/Documentation/git-cherry.txt
> index 7deefda..100ed69 100644
> --- a/Documentation/git-cherry.txt
> +++ b/Documentation/git-cherry.txt
> @@ -7,7 +7,7 @@ git-cherry - Find commits not merged upstream
>
> SYNOPSIS
> --------
> -'git cherry' [-v] [<upstream> [<head> [<limit>]]]
> +'git cherry' [-v] [-a|-#] [-r] [-d|-D] [<upstream> [<head> [<limit>]]]
>
> DESCRIPTION
> -----------
> @@ -49,6 +49,18 @@ OPTIONS
> -v::
> Verbose.
>
> +-a|-#::
> + Abbreviate commit ids to the given number of characters, or 7 for -a
> +
Why invent new convention, instead of using -<n> like git-log?
Why do not use --abbrev or --abbrev-commit? -<n> is used elsewhere
to limit number of commits...
> +-r::
> + Swap <upstream> and <head>
Why not -R like in git-diff?
> +
> +-d::
> + Only show commits that don't exist in upstream ("+" lines)
> +
> +-D::
> + Only show commits that do exist in upstream ("-" lines)
> +
I'm not sure if -d/-D is the best name of this short option...
> <upstream>::
> Upstream branch to compare against.
> Defaults to the first tracked remote branch, if available.
> --
> 1.5.4.3
>
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-05-30 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 1:39 [PATCH 1/2] add new output-tuning flags to 'git cherry' Jeff Epler
2009-05-30 1:39 ` [PATCH 2/2] document new flags Jeff Epler
2009-05-30 8:19 ` Jakub Narebski [this message]
2009-05-30 12:18 ` [PATCH 1/2] add new output-tuning flags to 'git cherry' Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38wkfatqc.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jepler@unpythonic.net \
--cc=unpythonic.net@unpythonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).