From: Andreas Schwab <schwab@linux-m68k.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Eric Wong <e@80x24.org>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 1/2] mailinfo: extract is_from_line from mailsplit
Date: Sun, 24 Jul 2016 10:13:31 +0200 [thread overview]
Message-ID: <m2lh0rzc5w.fsf@linux-m68k.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1607241003480.14111@virtualbox> (Johannes Schindelin's message of "Sun, 24 Jul 2016 10:05:16 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Andreas,
>
> On Sun, 24 Jul 2016, Andreas Schwab wrote:
>
>> Eric Wong <e@80x24.org> writes:
>>
>> > diff --git a/mailinfo.c b/mailinfo.c
>> > index 9f19ca1..0ebd953 100644
>> > --- a/mailinfo.c
>> > +++ b/mailinfo.c
>> > @@ -1035,3 +1035,34 @@ void clear_mailinfo(struct mailinfo *mi)
>> >
>> > strbuf_release(&mi->log_message);
>> > }
>> > +
>> > +int is_from_line(const char *line, int len)
>> > +{
>> > + const char *colon;
>> > +
>> > + if (len < 20 || memcmp("From ", line, 5))
>> > + return 0;
>> > +
>> > + colon = line + len - 2;
>> > + line += 5;
>> > + for (;;) {
>> > + if (colon < line)
>> > + return 0;
>> > + if (*--colon == ':')
>> > + break;
>> > + }
>> > +
>> > + if (!isdigit(colon[-4]) ||
>> > + !isdigit(colon[-2]) ||
>> > + !isdigit(colon[-1]) ||
>> > + !isdigit(colon[ 1]) ||
>> > + !isdigit(colon[ 2]))
>> > + return 0;
>> > +
>> > + /* year */
>> > + if (strtol(colon+3, NULL, 10) <= 90)
>> > + return 0;
>> > +
>> > + /* Ok, close enough */
>> > + return 1;
>> > +}
>>
>> Should this be made more strict, like by checking for a space before the
>> year?
>
> This patch only moves the function, so it would be inappropriate to change
> it.
>
> If you want to make it stricter, you will have to submit a separate patch.
You didn't answer my question.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-07-24 8:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 22:47 [PATCH] format-patch: escape "From " lines recognized by mailsplit Eric Wong
2016-07-23 8:59 ` Johannes Schindelin
2016-07-24 3:14 ` Eric Wong
2016-07-24 3:15 ` [PATCH 1/2] mailinfo: extract is_from_line from mailsplit Eric Wong
2016-07-24 7:37 ` Andreas Schwab
2016-07-24 8:05 ` Johannes Schindelin
2016-07-24 8:13 ` Andreas Schwab [this message]
2016-07-25 18:03 ` Junio C Hamano
2016-07-24 3:15 ` [PATCH 2/2] format-patch: escape "From " lines recognized by mailsplit Eric Wong
2016-07-24 7:37 ` Johannes Schindelin
2016-07-24 15:30 ` Jeff King
2016-07-24 7:11 ` [PATCH] " Junio C Hamano
2016-07-24 10:58 ` Eric Wong
2016-07-24 15:51 ` Junio C Hamano
2016-07-25 8:43 ` Eric Wong
2016-07-25 17:33 ` Junio C Hamano
2016-07-25 20:49 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lh0rzc5w.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).