git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	William Giokas <1007380@gmail.com>,
	git@vger.kernel.org
Subject: Re: [bug report] git-am applying maildir patches in reverse
Date: Sat, 02 Mar 2013 09:44:39 +0100	[thread overview]
Message-ID: <m28v66198o.fsf@igel.home> (raw)
In-Reply-To: <20130302004120.GB14936@sigill.intra.peff.net> (Jeff King's message of "Fri, 1 Mar 2013 19:41:20 -0500")

Jeff King <peff@peff.net> writes:

>  static int maildir_filename_cmp(const char *a, const char *b)
>  {
> -	while (1) {
> +	while (*a && *b) {
>  		if (isdigit(*a) && isdigit(*b)) {
>  			long int na, nb;
>  			na = strtol(a, (char **)&a, 10);
> @@ -148,6 +148,7 @@ static int maildir_filename_cmp(const char *a, const char *b)
>  			b++;
>  		}
>  	}
> +	return *a - *b;

You should always cast to unsigned char when determining the order of
characters, to be consistent with strcmp/memcmp.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2013-03-02  8:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 22:20 [bug report] git-am applying maildir patches in reverse William Giokas
2013-03-01 22:27 ` Junio C Hamano
2013-03-01 22:52   ` Jeff King
2013-03-01 23:05     ` Jeff King
2013-03-01 23:24       ` Junio C Hamano
2013-03-01 23:35         ` Jeff King
2013-03-01 23:57           ` Junio C Hamano
2013-03-02  0:38             ` Jeff King
2013-03-02  0:08           ` Junio C Hamano
2013-03-02  0:41             ` Jeff King
2013-03-02  8:44               ` Andreas Schwab [this message]
2013-03-03  6:22                 ` Junio C Hamano
2013-03-03  6:32                   ` Jeff King
2013-03-03  6:26                 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28v66198o.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=1007380@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).