From: Tanay Abhra <tanayabh@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH v8 2/2] test-config: add tests for the config_set API
Date: Tue, 15 Jul 2014 11:10:26 +0000 (UTC) [thread overview]
Message-ID: <loom.20140715T125714-160@post.gmane.org> (raw)
In-Reply-To: xmqq8unz4v4c.fsf@gitster.dls.corp.google.com
Junio C Hamano <gitster <at> pobox.com> writes:
>
> Tanay Abhra <tanayabh <at> gmail.com> writes:
>
> > diff --git a/test-config.c b/test-config.c
> > new file mode 100644
> > index 0000000..dc313c2
> > --- /dev/null
> > +++ b/test-config.c
> > <at> <at> -0,0 +1,125 <at> <at>
> > +
> > +
> > +int main(int argc, char **argv)
> > +{
> > + int i, val;
> > + const char *v;
> > + const struct string_list *strptr;
> > + struct config_set cs;
> > + git_configset_init(&cs);
> > +
> > + if (argc < 2) {
> > + fprintf(stderr, "Please, provide a command name on the command-line\n");
> > + return 1;
> > + } else if (argc == 3 && !strcmp(argv[1], "get_value")) {
> > + if (!git_config_get_value(argv[2], &v)) {
> > + if (!v)
> > + printf("(NULL)\n");
>
> This one is dubious. Is this for things like
>
> (in .git/config)
> [receive]
> fsckobjects
>
Yes, it was meant for the above case.
> and asking with
>
> $ git config receive.fsckobjects
>
> which I think gives an empty string? We may want to be consistent.
$ git config -l
shows NULL values as foo.bar
empty values as foo.bar=
So there is a difference between the two.
$ git config receive.fsckobjects does covert the NULL value to a ""(empty
string).
I had to diffrentiate between the two, so I took the path printf takes for
NULL strings, it prints them as "(NULL)".
prev parent reply other threads:[~2014-07-15 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 3:34 [PATCH v8 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-11 3:34 ` [PATCH v8 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-11 14:21 ` Matthieu Moy
2014-07-11 16:31 ` Tanay Abhra
2014-07-11 16:59 ` Matthieu Moy
2014-07-15 10:54 ` Tanay Abhra
2014-07-15 11:32 ` Matthieu Moy
2014-07-11 17:25 ` Junio C Hamano
2014-07-11 3:34 ` [PATCH v8 2/2] test-config: add tests for the config_set API Tanay Abhra
2014-07-11 14:24 ` Matthieu Moy
2014-07-11 14:27 ` [fixup PATCH 1/2] Call configset_clear Matthieu Moy
2014-07-11 14:27 ` [PATCH 2/2] Better tests for error cases Matthieu Moy
2014-07-11 18:18 ` [PATCH v8 2/2] test-config: add tests for the config_set API Junio C Hamano
2014-07-15 11:10 ` Tanay Abhra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20140715T125714-160@post.gmane.org \
--to=tanayabh@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).