From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nemina Amarasinghe Subject: Re: [PATCH] simplified the chain if() statements of =?utf-8?b?aW5zdGFsbF9icmFuY2hfY29uZmlnKCk=?= function in branch.c Date: Mon, 10 Mar 2014 09:15:10 +0000 (UTC) Message-ID: References: <878usia09y.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Mar 10 10:15:55 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMwJN-0003WK-Pl for gcvg-git-2@plane.gmane.org; Mon, 10 Mar 2014 10:15:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbaCJJPr (ORCPT ); Mon, 10 Mar 2014 05:15:47 -0400 Received: from plane.gmane.org ([80.91.229.3]:48588 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbaCJJPp (ORCPT ); Mon, 10 Mar 2014 05:15:45 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WMwJ6-0003Jq-Te for git@vger.kernel.org; Mon, 10 Mar 2014 10:15:36 +0100 Received: from 61.245.163.2 ([61.245.163.2]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 10 Mar 2014 10:15:36 +0100 Received: from neminaa by 61.245.163.2 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 10 Mar 2014 10:15:36 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 61.245.163.2 (Mozilla/5.0 (Windows NT 6.3; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: > > ((!remote_is_branch && origin) || (!remote_is_branch || !origin)) > > Is it? > > The above is the same as (!remote_is_branch || !origin). What you wrote > before is the same as (!remote_is_branch). > > Maybe you should try copy&paste from the expressions you are trying to > combine to make sure that what you start with makes sense. > OMG.. Really sorry for that... that was a silly mistake. This is the one.. ((!remote_is_branch && origin) || (!remote_is_branch && !origin))