From: Eric Blake <ebb9@byu.net>
To: git@vger.kernel.org
Subject: Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests
Date: Mon, 11 May 2009 20:04:25 +0000 (UTC) [thread overview]
Message-ID: <loom.20090511T195910-370@post.gmane.org> (raw)
In-Reply-To: 1242070141-2936-1-git-send-email-Don.Slutz@SierraAtlantic.com
Don Slutz <Don.Slutz <at> SierraAtlantic.com> writes:
>
> This is a patch set to do the work from mail message:
>
> http://kerneltrap.org/mailarchive/git/2007/8/7/254415
>
> It is split into 6 parts. This is because the tests do not work on
> Linux if autocrlf=true.
>
> 1) The change to autocrlf=true by default for cygwin
I help maintain the cygwin packaging of git, and I don't particularly like
patch 1/6. Cygwin very much recommends that users stick with binary mounts,
where cr's are not inserted/stripped by default, and enabling autocrlf in that
situation is asking for problems (namely, the same set of problems as you would
have on Linux with autocrlf=true). While adding an environment variable is
useful for the case of a user building git on cygwin with the intent of using a
text-mode mount, it goes against the grain of cygwin's recommendation of not
using text-mode mounts in the first place. I would rather see the default
remain false, even on cygwin, unless the person building git takes steps to
activate it themselves.
--
Eric Blake
next prev parent reply other threads:[~2009-05-11 20:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 19:28 [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests Don Slutz
2009-05-11 19:28 ` [PATCH 1/6] " Don Slutz
2009-05-11 19:28 ` [PATCH 2/6] Fix tests to work with core.autocrlf=true Don Slutz
2009-05-11 19:28 ` [PATCH 3/6] " Don Slutz
2009-05-11 19:28 ` [PATCH 4/6] " Don Slutz
2009-05-11 19:29 ` [PATCH 5/6] " Don Slutz
2009-05-11 19:29 ` [PATCH 6/6] Add 'make test-text' Don Slutz
2009-05-11 22:20 ` [PATCH 3/6] Fix tests to work with core.autocrlf=true Charles Bailey
2009-05-14 13:49 ` Don Slutz
2009-05-11 20:04 ` Eric Blake [this message]
2009-05-12 23:27 ` [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests Junio C Hamano
2009-05-13 17:41 ` Junio C Hamano
2009-05-11 20:54 ` Johannes Schindelin
2009-05-12 18:16 ` Don Slutz
2009-05-13 19:35 ` [PATCH v2 0/7] Add GIT_TEST_AUTO_CRLF environment variable to set core.autocrlf on init Don Slutz
2009-05-13 19:35 ` [PATCH v2 1/7] " Don Slutz
2009-05-13 19:35 ` [PATCH v2 2/7] Add support functions for tests in core.autocrlf=true Don Slutz
2009-05-13 19:35 ` [PATCH v2 3/7] Fix tests to work with core.autocrlf=true -- new functions Don Slutz
2009-05-13 19:35 ` [PATCH v2 4/7] Fix tests to work with core.autocrlf=true -- force false Don Slutz
2009-05-13 19:35 ` [PATCH v2 5/7] Fix tests to work with core.autocrlf=true -- cmp to test_cmp Don Slutz
2009-05-13 19:35 ` [PATCH v2 6/7] Fix tests to work with core.autocrlf=true -- test_cmp to cmp Don Slutz
2009-05-13 19:35 ` [PATCH v2 7/7] Add 'make test-text' core.autocrlf=true Don Slutz
2009-05-14 7:43 ` [PATCH v2 3/7] Fix tests to work with core.autocrlf=true -- new functions Charles Bailey
2009-05-14 14:39 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20090511T195910-370@post.gmane.org \
--to=ebb9@byu.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).