git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Dylan Reid <dgreid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] blame: can specify shas of commits to ignore on command  line
Date: Wed, 5 May 2010 01:28:08 -0400	[thread overview]
Message-ID: <l2wfd211a421005042228rd6386ff9k9bc54c5862209785@mail.gmail.com> (raw)
In-Reply-To: <7vfx27kjr6.fsf@alter.siamese.dyndns.org>

I've noticed that trying to come up with a solution tonight.  I'll
look at it some more tomorrow.  If you can't tell the difference
between added and changed then there would be no easy way to mark a
line as ignored either.

If the changes get split fine enough could you tell that blame_ent
doesn't exist in a parent commit?

Thanks,

Dylan

On Wed, May 5, 2010 at 1:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Dylan Reid <dgreid@gmail.com> writes:
>
>>> I am already confused.  If the command must return C when you say "ignore
>>> C" and C introduced a line you are interested in, then what is the point
>>> of specifying commits to be ignored?
>>>
>>
>> I was thinking that it would ignore changed lines, not added lines.  Make sense?
>
> Not really.  I don't think you can distinguish "changed lines" and "added
> lines" reliably.
>

  reply	other threads:[~2010-05-05  5:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04  2:21 [PATCH] blame: can specify shas of commits to ignore on command line Dylan Reid
2010-05-04 21:28 ` René Scharfe
2010-05-04 21:46   ` Dylan Reid
2010-05-04 23:01     ` Junio C Hamano
2010-05-04 23:08       ` Dylan Reid
2010-05-05  5:19         ` Junio C Hamano
2010-05-05  5:28           ` Dylan Reid [this message]
2012-03-08 21:01             ` cnighswonger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=l2wfd211a421005042228rd6386ff9k9bc54c5862209785@mail.gmail.com \
    --to=dgreid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).