From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-10.6 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id B09AE1F452 for ; Mon, 24 Apr 2023 18:53:17 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=wyoyirWi; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232514AbjDXSwn (ORCPT ); Mon, 24 Apr 2023 14:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232454AbjDXSwk (ORCPT ); Mon, 24 Apr 2023 14:52:40 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C4759762 for ; Mon, 24 Apr 2023 11:52:00 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-b92309d84c1so22784096276.1 for ; Mon, 24 Apr 2023 11:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682362316; x=1684954316; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pxvvpX/1igWMXqh2kdq37ZEsNlU2jM8AJPQkmf4jHrk=; b=wyoyirWisPS6qb057N30OA75XE79ouB243aNnj/LObh23qGwv67RmgG4BvZVdNYmIY K2VQ1VmppNKXUzD/hHR0XlRSr9yuDVlHgPlEzmm70Zd4dycxLy3tGXT2dpOxmfLvOk/6 6MZNXdAWi8VS3LsI7fqx7yjtEH9Xa3mvvgT4DHoOwhZqTguhFCKWeLHzlqGO1tJtm1zh ehxXFuOqoodwP+pVp9t07EEEx9l52QlCQwvmw6Ry9gKJAZp2rxrzwzqw33sQa0C64V+3 u0JaM/ThEaLydtQNleIRjsGSeXgXTsWrXn1WWkIpb94LwQFZ1NW4yYpNEOQzxF6B0OOB lPeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682362316; x=1684954316; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pxvvpX/1igWMXqh2kdq37ZEsNlU2jM8AJPQkmf4jHrk=; b=SCHZD9nsRXoWmMRf14SwWL818WhGqBtLicvk2jsKip+0Px5JatsExkdGSZYSVnCjU5 an9R83CFuZAR0sLJbSVMShYFKxYyONEyD3grxNKaRYXYFH3CpRxITTiAbn5AeE/D5u6G ath4lGQ05xt0P8Igxs04uuD2GjGQROkdapzZxRbIrgWgGKvaCs9keMuSMbkQiD0qzqVR UWl6VVXHV7cHYtLtebvp4RgloRU8kaUc0EJC7BzoSmzzw+gwOGrQgSMHGNDxg/EBQfo7 qnoQodzWK4Oc7vO+HvTzyMR7JBjTCGxl/g+h0hpZvEpNKIWPMKBrC9j9DamNrrQOpn02 ZE1g== X-Gm-Message-State: AAQBX9cYY6+uKUlFpPidpyhBsGaj/kOWV/2HwQN+vG7aGWevMnC1xFAg h7cPRKfHLL/qus64qvoIC7dHOVgrKkl7jw== X-Google-Smtp-Source: AKy350ZCUQei3Ne7KvumwwTg4hbQdp4MamG2U0J4EpZGnlUgern2wCBKvXfLQcwOhSq3pZx7EV3BKqdA/bqmlg== X-Received: from chooglen.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3a07]) (user=chooglen job=sendgmr) by 2002:a05:690c:9d:b0:555:a687:e151 with SMTP id be29-20020a05690c009d00b00555a687e151mr8219089ywb.3.1682362316709; Mon, 24 Apr 2023 11:51:56 -0700 (PDT) Date: Mon, 24 Apr 2023 11:51:54 -0700 In-Reply-To: Mime-Version: 1.0 References: Message-ID: Subject: Re: [PATCH v2 13/22] hash-ll.h: split out of hash.h to remove dependency on repository.h From: Glen Choo To: Elijah Newren via GitGitGadget , git@vger.kernel.org Cc: Calvin Wan , Derrick Stolee , Elijah Newren Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Elijah Newren via GitGitGadget" writes: > Move the parts of hash.h that do not > depend upon repository.h into a new file hash-ll.h (the "low level" > parts of hash.h), and adjust other files to use this new header where > the convenience inline functions aren't needed. Suggestion: To maintain this property, it might be helpful to capture the rules of hash-ll.h vs hash.h in a top-level comment. > diff --git a/hash-ll.h b/hash-ll.h > new file mode 100644 > index 00000000000..80509251370 > --- /dev/null > +++ b/hash-ll.h > +const struct object_id *null_oid(void); > [...] > +const char *empty_tree_oid_hex(void); > +const char *empty_blob_oid_hex(void); hash-ll.h doesn't depend on repository.h, but these functions' bodies use the_hash_algo. Does it matter? Moving the functions to hash.h requires changing 8 files to #include "hash.h", all of which seem to be because they were getting hash-ll.h indirectly via object-name.h.