Re: [PATCH v6 02/17] hook API: add a run_hooks() wrapper

[Glen Choo <chooglen@google.com>]

Ævar Arnfjörð Bjarmason         <avarab@gmail.com> writes:

> Add a run_hooks() wrapper, we'll use it in subsequent commits for the
> simple cases of wanting to run a single hook under a given name,
> without providing options such as "env" or "args".
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  hook.c | 7 +++++++
>  hook.h | 6 ++++++
>  2 files changed, 13 insertions(+)
>
> diff --git a/hook.c b/hook.c
> index a0917cf877c..d67a114e62d 100644
> --- a/hook.c
> +++ b/hook.c
> @@ -142,3 +142,10 @@ int run_hooks_opt(const char *hook_name, struct run_hooks_opt *options)
>  	run_hooks_opt_clear(options);
>  	return ret;
>  }
> +
> +int run_hooks(const char *hook_name)
> +{
> +	struct run_hooks_opt opt = RUN_HOOKS_OPT_INIT;
> +
> +	return run_hooks_opt(hook_name, &opt);
> +}
> diff --git a/hook.h b/hook.h
> index 782385cc235..9c358789958 100644
> --- a/hook.h
> +++ b/hook.h
> @@ -48,4 +48,10 @@ int hook_exists(const char *hookname);
>   * error().
>   */
>  int run_hooks_opt(const char *hook_name, struct run_hooks_opt *options);
> +
> +/**
> + * A wrapper for run_hooks_opt() which provides a dummy "struct
> + * run_hooks_opt" initialized with "RUN_HOOKS_OPT_INIT".
> + */
> +int run_hooks(const char *hook_name);
>  #endif
> -- 
> 2.34.1.1146.gb52885e7c44

This patch looks good. As a matter of personal taste, it's not ideal
that this is dead code, but it gets tested immediately in the subsequent
patches anyway, and those patches are pretty clear.