From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-10.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id E0E021F910 for ; Mon, 14 Nov 2022 23:39:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="EwWa8cog"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231990AbiKNXjZ (ORCPT ); Mon, 14 Nov 2022 18:39:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbiKNXjY (ORCPT ); Mon, 14 Nov 2022 18:39:24 -0500 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7A0101F1 for ; Mon, 14 Nov 2022 15:39:23 -0800 (PST) Received: by mail-pf1-x44a.google.com with SMTP id e12-20020a62aa0c000000b0056c12c0aadeso6857534pff.21 for ; Mon, 14 Nov 2022 15:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=dSwdia4Ksf15ceVewCKK5/fh1o2zFzkDvF+0Udocg2E=; b=EwWa8cog57YGBBdhzTu50sqV4EZZZTttr6v1QZqHLNARhXamG6zeYT39JBW53itEEK lNmanDIEX0C+fylWlszcGlXhEonfR/5dL3EukPTRuCIZs4U28rICoy7B6ED7tbUPXNer E+c8Gv3rWtsHI79lCqXRTIyWSiASgtv1kV5elNv2z0/Jc5rClWrq4Ptd8f9GHuqDZuDk 8nsg3X5cygp5lgYYF/maBr6fiSraTex7nkhisg10GMags7FtIaF1SKGJfcuWwnOpADDI 3/POFFHCaVplum6w2PuZnkxKrd/lvbIHTFn41u0BKePPe3VxEyF7WVEWs53+OrniP3Zg 56fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dSwdia4Ksf15ceVewCKK5/fh1o2zFzkDvF+0Udocg2E=; b=UOtrESwCxA02cQlZof7pO5za/fmSpu5Hcsx35NDAaK+q/RCvHeiegdwmYO/FT+1KCD wyRDxJ0O5TJDyiG2iFPVH4AGTwbWJVjx9XN/evPYI2qN1wKMGq7GZyaxhro6wycPNJ1R 9ug+L5tcQNXPin+X1N7IUO7YCmQU7vEF2WBedB9Ob6WYLHbMUyBTgmC8id/BDuuMeDas zXfsKouP8TB3N3JyK4IP7zEj9vxaT3bwx8DsgZEPG1ko9drtG6tHx25+qNNA7T6bRSzp wPS9klOA70CJ96mycq+xHEUh6iE0vas3Hx/XbF/w6bu7pdDrK4VW9oTOfWMgK0gqPGO8 vr6Q== X-Gm-Message-State: ANoB5pnfqF8jeCEIXXnj4LlMLalg0uw7K1rOx+IwJ1lTiDh7anRXwSEQ sk8Gl0rjVNApXUgKfNlUaIdg5Lt8EpIYiw== X-Google-Smtp-Source: AA0mqf6ML3KdlczirJOLM4GE1W9fl56AGIVcIa2/la5A5u8JukJ40Pt1f6S9PG/cvVU4IWEFGlJ0h9knmddHyg== X-Received: from chooglen.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:26d9]) (user=chooglen job=sendgmr) by 2002:a17:90a:d34e:b0:20b:1f6:3fe0 with SMTP id i14-20020a17090ad34e00b0020b01f63fe0mr15930227pjx.125.1668469163503; Mon, 14 Nov 2022 15:39:23 -0800 (PST) Date: Mon, 14 Nov 2022 15:39:22 -0800 In-Reply-To: Mime-Version: 1.0 References: Message-ID: Subject: Re: [PATCH v2 00/10] Get rid of "git --super-prefix" From: Glen Choo To: "=?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason" , git@vger.kernel.org, Taylor Blau Cc: Robert Coup , "=?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > It's also proposing to replace Glen's one-patch[6], which is working > around the problem shown in the test added in 1/10 here. Per > downthread of [7] I think Glen was aiming for getting a more narrow > fix in case we split off 9/10 here into some later fix. > > As we're fixing an edge case in something that's always been broken > (and thus wouldn't backport) I think it's better to just fix the > problem directly, rather than introducing new "--super-prefix" use, > just to take it away later. I still prefer that we take the one-patch to unbreak new releases, because partial clone + submodules is absolutely broken (e.g. it's already causing quite a lot of headaches at $DAYJOB) and the patch is obviously harmless. And more importantly, it lets us take our time with this series and get it right without time pressure. It's not as pressing as, e.g. a regression fix, but it does render certain Git setups unusable. With regards to urgency and when to choose "small and harmless fixes vs bigger and better fixes", I think Junio has generally made those calls in the past. @Taylor if you have an opinion, I'd love to hear it. > 6. https://lore.kernel.org/git/pull.1378.git.git.1668210935360.gitgitgadg= et@gmail.com/ > 7. https://lore.kernel.org/git/221111.86fsepmbhe.gmgdl@evledraar.gmail.co= m/